Ubuntu Calendar App

Merge lp://qastaging/~nik90/ubuntu-calendar-app/migrate-listitemlayout into lp://qastaging/ubuntu-calendar-app

  1. migrate-listitemlayout
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 764
Merged at revision: 761
Proposed branch: lp://qastaging/~nik90/ubuntu-calendar-app/migrate-listitemlayout
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 805 lines (+229/-266)
5 files modified
CalendarChoicePopup.qml (+88/-86)
CalendarListButtonDelegate.qml (+0/-51)
Settings.qml (+43/-80)
calendar.qml (+1/-4)
po/com.ubuntu.calendar.pot (+97/-45)
To merge this branch: bzr merge lp://qastaging/~nik90/ubuntu-calendar-app/migrate-listitemlayout
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Dan Chapman  Approve
Review via email: mp+287309@code.qastaging.launchpad.net

Commit message

- Changed the app background color to #FFFFFF (as per new design spec)
- Switches the following pages to listitemlayout
    - SettingsPage.qml
    - CalendarChoicePopup.qml

Description of the change

Switches the following pages to listitemlayout
- SettingsPage.qml
- CalendarChoicePopup.qml

To post a comment you must log in.
lp://qastaging/~nik90/ubuntu-calendar-app/migrate-listitemlayout updated
763. By Nekhelesh Ramananthan

Removed app background gradient as it is not supported and changed background color to white as requested by design

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:762
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1074/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/630/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1074/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:763
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1075/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/631/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1075/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Dan Chapman  (dpniel) wrote :

Looking good, just a couple of comments inline :-)

review: Needs Fixing
lp://qastaging/~nik90/ubuntu-calendar-app/migrate-listitemlayout updated
764. By Nekhelesh Ramananthan

Removed square brackets and changed back to ListView

Revision history for this message
Dan Chapman  (dpniel) wrote :

Looks good to me. Thanks!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:764
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1101/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/658/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1101/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: