Ubuntu Calendar App

Merge lp://qastaging/~nik90/ubuntu-calendar-app/revamp-calendarchoicepage into lp://qastaging/ubuntu-calendar-app

  1. revamp-calendarchoicepage
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 405
Merged at revision: 401
Proposed branch: lp://qastaging/~nik90/ubuntu-calendar-app/revamp-calendarchoicepage
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 202 lines (+83/-83)
1 file modified
CalendarChoicePopup.qml (+83/-83)
To merge this branch: bzr merge lp://qastaging/~nik90/ubuntu-calendar-app/revamp-calendarchoicepage
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Approve
Review via email: mp+231176@code.qastaging.launchpad.net

Commit message

Fixed bug #1357266 and revamped calendar choice page with license headers, new headers.

Description of the change

This MP implements the following,
- Transition the calendar choice page to the new headers
- Added copyright license headers
- Switched ListItem.Empty to ListItem.Standard which provides a control component
- Cleaned up code overall

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:404
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/691/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1592
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1592/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/249

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/691/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:405
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/692/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1594
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1594/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/250

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/692/rebuild

review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me Nekhelesh. Works expected on desktop.

Thanks for Mr.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/270/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1598
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1598/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/90

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: