Ubuntu Clock App

Merge lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend into lp://qastaging/ubuntu-clock-app

  1. add-utility-backend
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 349
Merged at revision: 341
Proposed branch: lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend
Merge into: lp://qastaging/ubuntu-clock-app
Diff against target: 275 lines (+182/-2)
7 files modified
backend/CMakeLists.txt (+24/-2)
backend/modules/Clock/Utility/backend.cpp (+34/-0)
backend/modules/Clock/Utility/backend.h (+35/-0)
backend/modules/Clock/Utility/customalarmsound.cpp (+39/-0)
backend/modules/Clock/Utility/customalarmsound.h (+46/-0)
backend/modules/Clock/Utility/qmldir (+2/-0)
debian/changelog (+2/-0)
To merge this branch: bzr merge lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+268490@code.qastaging.launchpad.net

Commit message

Added a clock utility c++ plugin housing customalarmsound type which is needed for the upcoming custom alarm sound feature.

Description of the change

Added a c++ backend plugin for
a) deleting files
b) returning the QStandardPath /home/phablet/.local/share/com.ubuntu.clock

This is necessary for the upcoming custom-alarm-sound feature implementation which requires the above mentioned functionalities.

To post a comment you must log in.
lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend updated
343. By Nekhelesh Ramananthan

removed clock utility import

344. By Nekhelesh Ramananthan

Fixed copyright year in backend.h

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:342
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/767/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/112/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/767/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:344
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/768/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/113/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/768/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend updated
345. By Nekhelesh Ramananthan

Remove qCritical statement

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:345
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/769/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/114

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/769/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

some inline comments.

review: Needs Information
lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend updated
346. By Nekhelesh Ramananthan

Merged standardpath and filemanagement into customalarmsound

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:346
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/778/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/123

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/778/rebuild

review: Approve (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend updated
347. By Nekhelesh Ramananthan

Updated debian changelog

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:347
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/780/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/125

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/780/rebuild

review: Approve (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/add-utility-backend updated
348. By Nekhelesh Ramananthan

Removed Quick and GUI module loading for clock utility

349. By Nekhelesh Ramananthan

Merged lp:ubuntu-clock-app

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

* Does the MP add/remove user visible strings? If Yes, has the pot file been
    updated?

No strings changed.

* Does the MP change the UI? If Yes, has it been approved by design?

No UX change

* Did you perform an exploratory manual test run of your code change and any
    related functionality?

Extensive testing done on desktop and phone

* If the MP fixes a bug or implements a feature, are there accompanying unit
    and autopilot tests?

Not required

* Is the clock app trunk buildable and runnable using Qtcreator?

Yes
* Was the debian changelog updated?

Yes

* Was the copyright years updated if necessary?

Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches