Merge lp://qastaging/~nik90/ubuntu-clock-app/change-confirmation-icon into lp://qastaging/ubuntu-clock-app
Proposed by
Nekhelesh Ramananthan
| Status: | Merged |
|---|---|
| Approved by: | Bartosz Kosiorek |
| Approved revision: | 331 |
| Merged at revision: | 331 |
| Proposed branch: | lp://qastaging/~nik90/ubuntu-clock-app/change-confirmation-icon |
| Merge into: | lp://qastaging/ubuntu-clock-app |
| Diff against target: |
38 lines (+3/-3) 3 files modified
app/alarm/AlarmLabel.qml (+1/-1) app/alarm/AlarmRepeat.qml (+1/-1) app/alarm/AlarmSound.qml (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~nik90/ubuntu-clock-app/change-confirmation-icon |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bartosz Kosiorek | Approve | ||
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Changed confirmation icon used in AlarmLabel, AlarmRepeat and AlarmSound to be consistent with the rest of the app.
Description of the change
The EditAlarmPage uses the "ok" icon to denote confirmation. I just noticed that I used "tick" icon as confirmation in AlarmLabel, AlarmSound and AlarmRepeat pages. So I just changed them all to "ok" to maintain consistency.
No debian changelog entry required since this is just fixing a typo from the previous commit that landed.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:331
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://