Ubuntu Clock App

Merge lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests into lp://qastaging/ubuntu-clock-app

  1. fix-failing-ap-tests
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 462
Merged at revision: 455
Proposed branch: lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests
Merge into: lp://qastaging/ubuntu-clock-app
Prerequisite: lp://qastaging/~nik90/ubuntu-clock-app/dynamic-load-listview
Diff against target: 728 lines (+149/-161)
12 files modified
app/MainPage.qml (+2/-0)
app/alarm/AlarmDelegate.qml (+6/-1)
app/alarm/AlarmList.qml (+2/-0)
app/alarm/AlarmRepeat.qml (+5/-2)
app/alarm/AlarmSound.qml (+1/-1)
app/alarm/EditAlarmPage.qml (+1/-0)
app/worldclock/UserWorldCityList.qml (+3/-2)
app/worldclock/WorldCityList.qml (+1/-3)
debian/changelog (+1/-0)
tests/autopilot/ubuntu_clock_app/__init__.py (+112/-138)
tests/autopilot/ubuntu_clock_app/tests/test_alarm.py (+14/-13)
tests/autopilot/ubuntu_clock_app/tests/test_clock.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Jenkins Bot continuous-integration Approve
Nicholas Skaggs Pending
Review via email: mp+287866@code.qastaging.launchpad.net

Commit message

Fixed all failing AP tests.

Description of the change

Fixed all failing AP tests.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:456
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/80/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/669/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/80/rebuild

review: Approve (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests updated
457. By Nekhelesh Ramananthan

Uncommited different alarm test cases and also added dynamic time setting to reduce test duration

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:457
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/81/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/670/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/81/rebuild

review: Approve (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests updated
458. By Nekhelesh Ramananthan

Fixed pep8 errors

459. By Nekhelesh Ramananthan

Fixed flake errors

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:459
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/82/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/671/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/82/rebuild

review: Approve (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests updated
460. By Nekhelesh Ramananthan

Properly assert alarm creation by checking the alarm time, name, occurrence and enabled status

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:460
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/84/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/673/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/84/rebuild

review: Approve (continuous-integration)
lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests updated
461. By Nekhelesh Ramananthan

Updated debian changelog

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:461
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/85/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/674/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/85/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Awensome work!
Thanks Nekhelesh.

review: Approve
lp://qastaging/~nik90/ubuntu-clock-app/fix-failing-ap-tests updated
462. By Nekhelesh Ramananthan

Merged lp:ubuntu-clock-app

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches