Merge lp://qastaging/~nik90/ubuntu-clock-app/minor-fixes-new-design into lp://qastaging/ubuntu-clock-app
Proposed by
Nekhelesh Ramananthan
| Status: | Merged |
|---|---|
| Approved by: | Nekhelesh Ramananthan |
| Approved revision: | 449 |
| Merged at revision: | 446 |
| Proposed branch: | lp://qastaging/~nik90/ubuntu-clock-app/minor-fixes-new-design |
| Merge into: | lp://qastaging/ubuntu-clock-app |
| Diff against target: |
135 lines (+16/-24) 6 files modified
app/MainPage.qml (+0/-2) app/components/ActionIcon.qml (+1/-4) app/components/HeaderNavigation.qml (+5/-5) app/stopwatch/LapListView.qml (+9/-4) app/ubuntu-clock-app.qml (+0/-9) debian/changelog (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~nik90/ubuntu-clock-app/minor-fixes-new-design |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jenkins Bot | continuous-integration | Approve | |
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Reduced bindings in ActionIcon.qml
- Removed unnecessary QtQuick.Layout import
- Fixed stopwatch swipe delete UI issue introduced in new design implementation
Description of the change
- Reduced bindings in ActionIcon.qml
- Removed unnecessary QtQuick.Layout import
- Fixed stopwatch swipe delete UI issue introduced in new design implementation
Steps to reproduce the stopwatch swipe delete issue in trunk,
1. Start stopwatch and create 2-3 laps.
2. Swipe right to show the delete icon. Don't delete the lap though.
3. Instead swipe left to hide the delete icon.
Notice in step 3 that the delete icon doesn't fully go back to hiding.
To post a comment you must log in.
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Check list,
* Does the MP add/remove user visible strings? If Yes, has the pot file been
updated?
Not applicable
* Does the MP change the UI? If Yes, has it been approved by design?
No UI Changes
* Did you perform an exploratory manual test run of your code change and any
related functionality?
Yes
* If the MP fixes a bug or implements a feature, are there accompanying unit
and autopilot tests?
None
* Is the clock app trunk buildable and runnable using Qtcreator?
Yes
* Was the debian changelog updated?
Yes
* Was the copyright years updated if necessary?
Not applicable.