Merge lp://qastaging/~nikwen/account-polld/fix-qtcontacts-timeout-error into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

Proposed by Niklas Wenzel
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 139
Merged at revision: 146
Proposed branch: lp://qastaging/~nikwen/account-polld/fix-qtcontacts-timeout-error
Merge into: lp://qastaging/~ubuntu-push-hackers/account-polld/trunk
Prerequisite: lp://qastaging/~nikwen/account-polld/fix-timeout-handler
Diff against target: 63 lines (+23/-3)
2 files modified
cmd/account-polld/account_manager.go (+2/-0)
cmd/account-polld/main.go (+21/-3)
To merge this branch: bzr merge lp://qastaging/~nikwen/account-polld/fix-qtcontacts-timeout-error
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+273356@code.qastaging.launchpad.net

Commit message

Fix a timeout error in the qtcontacts module which occured when a notification was shown directly after creating an account (fixes LP: #1498214)

Description of the change

Fix a timeout error in the qtcontacts module which occured when a notification was shown directly after creating an account (fixes LP: #1498214)

This depends on https://code.launchpad.net/~nikwen/account-polld/fix-timeout-handler/+merge/273351

To post a comment you must log in.
Revision history for this message
Niklas Wenzel (nikwen) wrote :

This does actually need review! It's no WIP anymore.

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches