Merge lp://qastaging/~nikwen/ubuntu-calculator-app/desktop-paste-support into lp://qastaging/ubuntu-calculator-app

Proposed by Niklas Wenzel
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 210
Merged at revision: 228
Proposed branch: lp://qastaging/~nikwen/ubuntu-calculator-app/desktop-paste-support
Merge into: lp://qastaging/ubuntu-calculator-app
Prerequisite: lp://qastaging/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix
Diff against target: 57 lines (+47/-0)
1 file modified
app/ubuntu-calculator-app.qml (+47/-0)
To merge this branch: bzr merge lp://qastaging/~nikwen/ubuntu-calculator-app/desktop-paste-support
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Bartosz Kosiorek Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+266662@code.qastaging.launchpad.net

Commit message

Add proper paste support on the desktop

Description of the change

Add proper paste support on the desktop

(This is one of two MPs resulting from splitting https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621)

To post a comment you must log in.
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Great work.
Let's wait with this feature push for UX comment.

I think it will be good to discuss about possible solutions.

review: Needs Fixing
Revision history for this message
Bartosz Kosiorek (gang65) :
review: Abstain
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Sorry Niklas.

I completely forgot about this MR.
I have some comments:
 1. Could you please update debian/changelog. It is very nice feature and it will be nice to add it into changelog
 2. There is an issue when I pasting "0.1" text. It is pushing only ".1". Do you know why it is happen?

Best Regards
bartosz

review: Needs Fixing
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) :
review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Hi Bartosz,

Thank you for your review! :)

Given that you merged it before I had the chance to add a changelog entry, I'll add another MP for that. ;)
The 0.1 struggle is real though! It looks as if pasting 0 fails in general. I'll have a look at it. :)

Thanks again,
Niklas

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Here's the fix for the zero pasting issue: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/paste-zero-fix/+merge/276011
Evil one! :D

Regarding the changelog: To me this looks as if it is automatically generated somehow. Is this true? If it is, how can I generate it from the bzr history?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches