Ubuntu Calculator App

Merge lp://qastaging/~nikwen/ubuntu-calculator-app/paste-zero-fix into lp://qastaging/ubuntu-calculator-app

  1. paste-zero-fix
  2. Merge into trunk
Proposed by Niklas Wenzel
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 230
Merged at revision: 235
Proposed branch: lp://qastaging/~nikwen/ubuntu-calculator-app/paste-zero-fix
Merge into: lp://qastaging/ubuntu-calculator-app
Diff against target: 16 lines (+2/-2)
1 file modified
app/ubuntu-calculator-app.qml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~nikwen/ubuntu-calculator-app/paste-zero-fix
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Jenkins Bot continuous-integration Approve
Ubuntu Calculator Developers Pending
Review via email: mp+276011@code.qastaging.launchpad.net

Commit message

Fix issue due to which the zero would not be pasted when using Ctrl+V

Description of the change

Fix issue due to which the zero would not be pasted when using Ctrl+V

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:230
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/8/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/72/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/8/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:230
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/365/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/87

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/365/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

If you paste "sin(10)" then last bracket will not be pasted (it will be "sin(10".

Could you please fix that.

Also autopilot tests for paste, will be very useful.

review: Needs Fixing
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you for your review, Bartosz. I'll fix the brackets thing as soon as possible.

However, I'm incredibly busy at the moment and it will take at least one and a half weeks until I have time for that again.

Regarding the autopilot tests: I don't know how to fit them into my schedule at the moment. If you write some though, I'll happily review them. :)

Cheers,
Niklas

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Your solution is good. I will separate this bug from bracket bug.
I have created bug report related to bracket paste issue:
https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1516321

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you for merging then. I hope to fix the other issue soon. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches