Ubuntu Calculator App

Merge lp://qastaging/~nikwen/ubuntu-calculator-app/reboot-keyboard-buttons-haptic-feedback into lp://qastaging/ubuntu-calculator-app

  1. reboot-keyboard-buttons-haptic-feedback
  2. Merge into trunk
Proposed by Niklas Wenzel
Status: Merged
Merged at revision: 157
Proposed branch: lp://qastaging/~nikwen/ubuntu-calculator-app/reboot-keyboard-buttons-haptic-feedback
Merge into: lp://qastaging/ubuntu-calculator-app
Diff against target: 76 lines (+5/-20)
2 files modified
app/tests/autopilot/ubuntu_calculator_app/__init__.py (+3/-9)
app/ui/KeyboardButton.qml (+2/-11)
To merge this branch: bzr merge lp://qastaging/~nikwen/ubuntu-calculator-app/reboot-keyboard-buttons-haptic-feedback
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Bartosz Kosiorek Approve
Review via email: mp+255884@code.qastaging.launchpad.net

Commit message

Added haptic feedback to keyboard buttons by removing unnecessary MouseArea

Description of the change

Added haptic feedback to keyboard buttons by removing unnecessary MouseArea

To post a comment you must log in.
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Sorry for creating multiple merge proposals. I messed up some branches.

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Very nice improvement. I didn't notice that issue previously.

Thanks Niklas.

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Wow, thanks for the fast approval. Let's see what the automatic test results say. ;)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:157
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/297/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2554
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2554/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/76
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-vivid-amd64-ci/19

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/297/rebuild

review: Approve (continuous-integration)
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Great. Someone who wants to do a top-level approve?

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:157
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/144/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2555
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2555/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-utopic-amd64-ci/37
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-vivid-amd64-ci/144

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/144/rebuild

review: Approve (continuous-integration)
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thanks for merging. :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-autolanding/94/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2557
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2557/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-utopic-amd64-autolanding/29
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-vivid-amd64-autolanding/94

review: Needs Fixing (continuous-integration)
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Why did it try to merge that twice? Jenkins Bot issues?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches