Merge lp://qastaging/~njpatel/unity/fix-panel-opacity into lp://qastaging/unity
Proposed by
Neil J. Patel
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1517 | ||||
| Proposed branch: | lp://qastaging/~njpatel/unity/fix-panel-opacity | ||||
| Merge into: | lp://qastaging/unity | ||||
| Diff against target: |
147 lines (+21/-11) 7 files modified
plugins/unityshell/src/PanelController.cpp (+6/-1) plugins/unityshell/src/PanelController.h (+2/-0) plugins/unityshell/src/PanelStyle.cpp (+6/-2) plugins/unityshell/src/PanelStyle.h (+1/-1) plugins/unityshell/src/PanelView.cpp (+3/-4) plugins/unityshell/src/unityshell.cpp (+1/-1) services/panel-service.c (+2/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~njpatel/unity/fix-panel-opacity | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrea Cimitan (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fixes the panel opacity to work better with the blending modes we now use (do the opacity at paint time). Also adds a nicety so that we don't paint a shadow/blur if the opacity is 0.0f (which most people are using for an uber-clean look).
The drawing code needs to be cleaned up to not be as crazy, but this branch wasn't meant to do that so will leave it until after release.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Seems correctly done to me