Merge lp://qastaging/~nmessick/ubuntu/quantal/ec2-ami-tools/1.4.0.7 into lp://qastaging/ubuntu/quantal/ec2-ami-tools

Hi,
  Thanks for taking the time to put this together.
  A few things stick out on first glance:
- your changelog entry calls out support for several regions that were previously known. The current archive version (1.4.0.2) knows about up to 'us-west-2'. Changelogs should generally call out changes since last ubuntu package.
- it doesn't seem like you've merged the upstream source in correctly. You should start off by doing something like:
   bzr merge-upstream --version 1.4.0.7 ../../dl/ec2-ami-tools-1.4.0.7.tar.gz
   Then quilt push ... quilt refresh .. quilt pop
- We want to at very least keep the intent of remove-explicit-regions.patch. The changes provided by Amazon are still insufficient, as arrival of a new region means we have to ship an explicit patch to add the hard coded region list. The patch provided there knows explicitly of a list of regions, but then assumes that if ec2.<region>.amazon.aws.com exists as a dns record that the region is legitimate.
- note, for getting a tarball from a zip, I've used 'repack-zip' that i put together in the iamcli package (http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/iamcli/quantal/view/head:/debian/repack-zip) and then done something like: ./repack.zip http://s3.amazonaws.com/ec2-downloads/ec2-ami-tools-1.4.0.7.zip

I do realize that you probably spent considerable time figuring out just how to work with this package and for that I apologize. Thanks for the work, fix up those items and we can get a new version uploaded.

Also, feel free to document anything that you think might make this easier for someone else.

Yeah, I was actually following the Ubuntu Packaging Guide in order to to
the upgrade, and that has a much different workflow than this.

I'll do it this way and resubmit.

Nick

On Wednesday, July 25, 2012, Scott Moser wrote:

> Review: Needs Fixing
>
> Hi,
> Thanks for taking the time to put this together.
> A few things stick out on first glance:
> - your changelog entry calls out support for several regions that were
> previously known. The current archive version (1.4.0.2) knows about up to
> 'us-west-2'. Changelogs should generally call out changes since last
> ubuntu package.
> - it doesn't seem like you've merged the upstream source in correctly.
> You should start off by doing something like:
> bzr merge-upstream --version 1.4.0.7
> ../../dl/ec2-ami-tools-1.4.0.7.tar.gz
> Then quilt push ... quilt refresh .. quilt pop
> - We want to at very least keep the intent of
> remove-explicit-regions.patch. The changes provided by Amazon are still
> insufficient, as arrival of a new region means we have to ship an explicit
> patch to add the hard coded region list. The patch provided there knows
> explicitly of a list of regions, but then assumes that if ec2.<region>.
> amazon.aws.com exists as a dns record that the region is legitimate.
> - note, for getting a tarball from a zip, I've used 'repack-zip' that i
> put together in the iamcli package (
> http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/iamcli/quantal/view/head:/debian/repack-zip)
> and then done something like: ./repack.zip
> http://s3.amazonaws.com/ec2-downloads/ec2-ami-tools-1.4.0.7.zip
>
>
> I do realize that you probably spent considerable time figuring out just
> how to work with this package and for that I apologize. Thanks for the
> work, fix up those items and we can get a new version uploaded.
>
> Also, feel free to document anything that you think might make this easier
> for someone else.
>
> --
>
> https://code.launchpad.net/~nmessick/ubuntu/quantal/ec2-ami-tools/1.4.0.7/+merge/116699
> You are the owner of lp:~nmessick/ubuntu/quantal/ec2-ami-tools/1.4.0.7.
>

--
Nick Messick
<email address hidden>