Merge lp://qastaging/~noskcaj/tasksel/ubuntu-gnome into lp://qastaging/~ubuntu-core-dev/tasksel/ubuntu

Proposed by Jackson Doak
Status: Merged
Merged at revision: 1490
Proposed branch: lp://qastaging/~noskcaj/tasksel/ubuntu-gnome
Merge into: lp://qastaging/~ubuntu-core-dev/tasksel/ubuntu
Diff against target: 73 lines (+26/-1)
5 files modified
Makefile (+1/-1)
debian/changelog (+6/-0)
ubuntu-seeds.pl (+3/-0)
ubuntu-tasks/ubuntu-gnome-desktop (+7/-0)
ubuntu-tasks/ubuntu-gnome-live (+9/-0)
To merge this branch: bzr merge lp://qastaging/~noskcaj/tasksel/ubuntu-gnome
Reviewer Review Type Date Requested Status
Colin Watson Approve
Tim Lunn (community) Approve
Review via email: mp+213540@code.qastaging.launchpad.net

Description of the change

Add ubuntu-gnome

To post a comment you must log in.
Revision history for this message
Tim Lunn (darkxst) wrote :

Noskcaj, you can't use dashes in variable names.

$ubuntu-gnome_seed_base will not work and should instead be:
$ubuntu_gnome_seed_base

review: Needs Fixing
1492. By Jackson Doak

don't use hyphens

Revision history for this message
Jackson Doak (noskcaj) wrote :

Should be fixed now

Revision history for this message
Tim Lunn (darkxst) wrote :

ok, that is better!

review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks for this. For future reference, files in ubuntu-tasks/ are not to be edited manually - the best way to regenerate them is 'rm -rf ubuntu-tasks && make ubuntu-tasks'. I'll fix this up.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: