TestDrive

Merge lp://qastaging/~noskcaj/testdrive/pep8 into lp://qastaging/testdrive

pep8
Merge into trunk

Proposed by Jackson Doak on 2013-10-06

Status:	Needs review
Proposed branch:	lp://qastaging/~noskcaj/testdrive/pep8
Merge into:	lp://qastaging/testdrive
Diff against target:	3322 lines (+922/-571) 17 files modified bin/testdrive (+106/-51) bin/testdrive-gtk (+250/-152) debian/changelog (+4/-6) debian/control (+2/-1) debian/copyright (+5/-0) debian/release.sh (+1/-1) po/testdrive.pot (+177/-132) setup.py (+30/-28) testdrive/testdrive.py (+75/-36) testdrive/virt/kvm.py (+22/-8) testdrive/virt/parallels.py (+18/-7) testdrive/virt/virtualbox.py (+55/-25) testdrivegtk/AboutTestdrivegtkDialog.py (+20/-17) testdrivegtk/AddOtherTestdrivegtkDialog.py (+31/-19) testdrivegtk/PreferencesTestdrivegtkDialog.py (+101/-65) testdrivegtk/helpers.py (+13/-12) testdrivegtk/testdrivegtkconfig.py (+12/-11)
To merge this branch:	bzr merge lp://qastaging/~noskcaj/testdrive/pep8
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Andres Rodriguez		2013-10-06	Needs Fixing on 2013-10-26
Review via email: mp+189491@code.qastaging.launchpad.net

Description of the change

makes the program pep8 compliant and adds some minor fixes.

lp://qastaging/~noskcaj/testdrive/pep8 updated on 2013-10-06

434. By Jackson Doak on 2013-10-06: prevent testdrive from importing gettext twice
435. By Jackson Doak on 2013-10-06: Comment out unused imports
436. By Jackson Doak on 2013-10-06: Fix minor text bugs i made.

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2013-10-26:

Hi Jackson!

I like this fixes for sure.. however, it is way too big to review.. is there anyway you can split this in smaller branches? (Say one branch per binary, so that it is easier to test and review).

thank you! this is awesome!

review: Needs Fixing

Revision history for this message

Jackson Doak (noskcaj) wrote on 2013-10-26:

first, thanks for having time to review.
second, I'll re-do this in separate branches one the PyGI (and maybe
python3) port is over. Is there any chance you could help with either,
since glade keep breaking for me and dan hasn't got the time.

On Sun, Oct 27, 2013 at 5:24 AM, Andres Rodriguez
<email address hidden>wrote:

> Review: Needs Fixing
>
> Hi Jackson!
>
> I like this fixes for sure.. however, it is way too big to review.. is
> there anyway you can split this in smaller branches? (Say one branch per
> binary, so that it is easier to test and review).
>
> thank you! this is awesome!
> --
> https://code.launchpad.net/~noskcaj/testdrive/pep8/+merge/189491
> You are the owner of lp:~noskcaj/testdrive/pep8.
>

Unmerged revisions

436. By Jackson Doak on 2013-10-06: Fix minor text bugs i made.
435. By Jackson Doak on 2013-10-06: Comment out unused imports
434. By Jackson Doak on 2013-10-06: prevent testdrive from importing gettext twice
433. By Jackson Doak on 2013-10-06: * debian/control: Add working VCS fields
* debian/release.sh: Update current ubuntu release
432. By Jackson Doak on 2013-10-06: Add copyright entry for testdrivegtk/AddOtherTestdrivegtkDialog.py
431. By Jackson Doak on 2013-10-06: Finish pep8 changes
430. By Jackson Doak on 2013-10-05: Make testdrive pep8 compliant