Merge lp://qastaging/~noskcaj/ubuntu/vivid/fedmsg-meta-fedora-infrastructure/disable-tests into lp://qastaging/ubuntu/vivid/fedmsg-meta-fedora-infrastructure
Proposed by
Jackson Doak
Status: | Work in progress |
---|---|
Proposed branch: | lp://qastaging/~noskcaj/ubuntu/vivid/fedmsg-meta-fedora-infrastructure/disable-tests |
Merge into: | lp://qastaging/ubuntu/vivid/fedmsg-meta-fedora-infrastructure |
Diff against target: |
872 lines (+577/-26) 19 files modified
PKG-INFO (+1/-1) debian/changelog (+12/-0) debian/control (+2/-1) debian/rules (+4/-0) fedmsg_meta_fedora_infrastructure.egg-info/PKG-INFO (+1/-1) fedmsg_meta_fedora_infrastructure.egg-info/SOURCES.txt (+2/-0) fedmsg_meta_fedora_infrastructure/coprs.py (+1/-1) fedmsg_meta_fedora_infrastructure/fedimg.py (+32/-15) fedmsg_meta_fedora_infrastructure/fedoracollege.py (+77/-0) fedmsg_meta_fedora_infrastructure/github.py (+12/-1) fedmsg_meta_fedora_infrastructure/jenkins.py (+6/-0) fedmsg_meta_fedora_infrastructure/pkgdb.py (+26/-1) fedmsg_meta_fedora_infrastructure/tests/coprs.py (+3/-1) fedmsg_meta_fedora_infrastructure/tests/fedimg.py (+31/-0) fedmsg_meta_fedora_infrastructure/tests/fedoracollege.py (+167/-0) fedmsg_meta_fedora_infrastructure/tests/github.py (+82/-0) fedmsg_meta_fedora_infrastructure/tests/jenkins.py (+78/-0) fedmsg_meta_fedora_infrastructure/tests/pkgdb.py (+39/-3) setup.py (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~noskcaj/ubuntu/vivid/fedmsg-meta-fedora-infrastructure/disable-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Needs Information | ||
Review via email:
|
Description of the change
Disable tests because they need web access. (So offline tests still run)
Is this change ok?
To post a comment you must log in.
Unmerged revisions
- 6. By Jackson Doak
-
Add comment to d/rules
- 5. By Jackson Doak
-
Disable tests because they need an internet connection
- 4. By Nicolas Dandrimont <email address hidden>
-
New upstream release
The change looks good to me as there is no other alternatives (or maybe marked all tests as skipped, but it seems they all need network connection).
Do you mind just noting in debian/rules on top of the override_ dh_auto_ test the reason? (it's easier than diving into the changelog)
Then, just ping me and I'll sponsor, thanks!