Merge lp://qastaging/~noskcaj/ubuntu/vivid/xfce4-xkb-plugin/lp-733563 into lp://qastaging/ubuntu/vivid/xfce4-xkb-plugin

Proposed by Jackson Doak
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://qastaging/~noskcaj/ubuntu/vivid/xfce4-xkb-plugin/lp-733563
Merge into: lp://qastaging/ubuntu/vivid/xfce4-xkb-plugin
Diff against target: 311 lines (+293/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/font_selection.patch (+286/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~noskcaj/ubuntu/vivid/xfce4-xkb-plugin/lp-733563
Reviewer Review Type Date Requested Status
Sebastien Bacher Disapprove
Review via email: mp+239668@code.qastaging.launchpad.net

Description of the change

Change font when the rest of the system does

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

There are some previous review comments on https://code.launchpad.net/~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563/+merge/214365

Would be nice to get an upstream review before uploading to Ubuntu, letting the review/decision to the xubuntu team in any case

Revision history for this message
Sebastien Bacher (seb128) wrote :

could somebody from the xubuntu team review that one?

Revision history for this message
Sebastien Bacher (seb128) wrote :

Seems like nobody from the xubuntu team is interested in picking that one up, marking as rejected, that doesn't seem like the sort of changes that should be done in a distro change but rather worked with upstream instead

review: Disapprove

Unmerged revisions

38. By Jackson Doak

Add font_selection.patch, thanks Ivan Frederiks. LP: #733563

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: