Merge lp://qastaging/~noskcaj/ubuntu/wily/dell-dup/dh-python into lp://qastaging/ubuntu/wily/dell-dup

Proposed by Jackson Doak
Status: Work in progress
Proposed branch: lp://qastaging/~noskcaj/ubuntu/wily/dell-dup/dh-python
Merge into: lp://qastaging/ubuntu/wily/dell-dup
Diff against target: 130 lines (+33/-35)
8 files modified
debian/changelog (+8/-0)
debian/compat (+1/-1)
debian/control (+13/-5)
debian/copyright (+1/-1)
debian/pycompat (+0/-1)
debian/pyversions (+0/-1)
debian/rules (+9/-26)
debian/source/format (+1/-0)
To merge this branch: bzr merge lp://qastaging/~noskcaj/ubuntu/wily/dell-dup/dh-python
Reviewer Review Type Date Requested Status
Jared Dominguez (community) Abstain
Mario Limonciello Abstain
Luke Faraone (community) Needs Information
Ubuntu branches Pending
Review via email: mp+264080@code.qastaging.launchpad.net

Description of the change

Switch to using dh and dh-python. This package might be better RMed though

To post a comment you must log in.
Revision history for this message
Luke Faraone (lfaraone) wrote :

We should probably check with ~superm1 as to whether this package is still useful, agreed.

review: Needs Information
Revision history for this message
Piotr Ożarowski (piotr) wrote :

is missing --buildsystem=pybuild in debian/rules intentional?

Revision history for this message
Jackson Doak (noskcaj) wrote :

Is pybuild needed?

On Wednesday, August 12, 2015, Piotr Ożarowski <email address hidden> wrote:

> is missing --buildsystem=pybuild in debian/rules intentional?
>
> --
>
> https://code.launchpad.net/~noskcaj/ubuntu/wily/dell-dup/dh-python/+merge/264080
> You are the owner of lp:~noskcaj/ubuntu/wily/dell-dup/dh-python.
>

Revision history for this message
Mario Limonciello (superm1) wrote :

jared is probably better to review if this is still relevant. Adding him.

review: Abstain
Revision history for this message
Jared Dominguez (jared-dominguez) wrote :

I'll need to check on whether this is needed at all anymore.

Revision history for this message
Jared Dominguez (jared-dominguez) wrote :

Changes in this package are fine with me, but the internal feedback I got is that this package is no longer in use by Dell for building DUPs.

review: Abstain
Revision history for this message
Michael Terry (mterry) wrote :

Sounds like this can be removed from the archive. I've filed bug 1491140 to do that (assigned to you, Jared to confirm it should go ahead -- if you say yes, we can subscribe ~ubuntu-archive).

In the meantime, I'll mark this branch as WIP to get it off the sponsors list.

Thanks, Jackson! Even though we may not use it, good patch. :)

Unmerged revisions

8. By Jackson Doak

Depend on firmware-tools, firmware-addon-dell

7. By Jackson Doak

Add missing build-depends

6. By Jackson Doak

* Switch to dh and dh-python
* Bump standards-version

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches