OpenStack Object Storage (swift)

Merge lp://qastaging/~notmyname/swift/access_log_delivery into lp://qastaging/~hudson-openstack/swift/trunk

  1. access_log_delivery
  2. Merge into trunk
Proposed by John Dickinson
Status: Rejected
Rejected by: gholt
Proposed branch: lp://qastaging/~notmyname/swift/access_log_delivery
Merge into: lp://qastaging/~hudson-openstack/swift/trunk
Prerequisite: lp://qastaging/~greglange/swift/lp725215
Diff against target: 1293 lines (+940/-169) (has conflicts)
10 files modified
bin/swift-access-log-delivery (+25/-0)
doc/source/overview_stats.rst (+63/-0)
etc/access-log-delivery.conf-sample (+19/-0)
swift/common/internal_proxy.py (+10/-0)
swift/common/utils.py (+37/-0)
swift/stats/access_log_delivery.py (+347/-0)
swift/stats/log_common.py (+180/-0)
swift/stats/log_processor.py (+14/-154)
test/unit/stats/test_access_log_delivery.py (+218/-0)
test/unit/stats/test_log_processor.py (+27/-15)
Text conflict in swift/stats/log_processor.py
To merge this branch: bzr merge lp://qastaging/~notmyname/swift/access_log_delivery
Reviewer Review Type Date Requested Status
Swift Core security contacts Pending
Review via email: mp+57191@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-03-21.

Description of the change

implementation of swift feature that allows for access logs to be delivered to a user's account

To post a comment you must log in.
Revision history for this message
Scott Simpson (sasimpson) wrote :

this needs to wait until after the stats changes get merged.

Revision history for this message
John Dickinson (notmyname) wrote :

there is no need to wait on this. all prerequisite branches have landed

Revision history for this message
Jay Payne (letterj) wrote :

On this first pass, Where is the requirement that the access logs must be transformed into the the Apache log format?

Revision history for this message
John Dickinson (notmyname) wrote :

Line 221 in the diff is the function that transforms it to Apache CLF.

Revision history for this message
Jay Payne (letterj) wrote :

We can talk more about this on Monday but I don't believe that this should be included in the swift project. There should either be a separate project for log processing or a contrib directory. While I can see the use for uploading the access logs, I think the account and container stats code should be used as a guide for each implementer to collect the stats they feel are important.

Revision history for this message
David Goetz (david-goetz) wrote :

If this does get put into swift- there should be some unit tests added for the new code. We're at 81% now, lets keep it up.

Revision history for this message
gholt (gholt) wrote :

swift/stats/log_common.py:127:1: E302 expected 2 blank lines, found 1

Needs more tests as dfg pointed out. [Down to 80% from 81% overall.]

While I'm all for separation of log processing / statistics to a separate project with some cool name, I don't it's time just yet.

Revision history for this message
gholt (gholt) wrote :

Just to further the end of my previous comment, for some reason I thought we had to have this in real-soon-now-or-else. If that's really not the case, it might be a good time to separate the projects after all. Let's give it some discussion when everyone's in the office.

lp://qastaging/~notmyname/swift/access_log_delivery updated
264. By John Dickinson

initial tests for access log delivery

Revision history for this message
gholt (gholt) wrote :

Okay, I think we're in a agreement to do the separate project thing for this and swauth, so "rejecting" merges. Fun! :)

Unmerged revisions

264. By John Dickinson

initial tests for access log delivery

263. By John Dickinson

additional docs for access log delivery

262. By John Dickinson

more doc info

261. By John Dickinson

updated docs with access-log-delivery info

260. By John Dickinson

merged with trunk

259. By John Dickinson

merged with trunk

258. By John Dickinson

consolidated functionality into log_common and fixed tests to reflect this

257. By John Dickinson

merged with ~greglange/swift/lp725215

256. By John Dickinson

merged with trunk

255. By John Dickinson

fixed imports

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.