Ubuntu Notes app

Merge lp://qastaging/~nskaggs/reminders-app/fix-1347905 into lp://qastaging/reminders-app

  1. fix-1347905
  2. Merge into trunk
Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 206
Merged at revision: 212
Proposed branch: lp://qastaging/~nskaggs/reminders-app/fix-1347905
Merge into: lp://qastaging/reminders-app
Diff against target: 59 lines (+2/-8)
4 files modified
debian/control (+1/-0)
manifest.json (+1/-1)
tests/autopilot/reminders/tests/test_credentials.py (+0/-4)
tests/autopilot/reminders/tests/test_reminders.py (+0/-3)
To merge this branch: bzr merge lp://qastaging/~nskaggs/reminders-app/fix-1347905
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Omer Akram (community) code Approve
Ubuntu Notes app developers Pending
Review via email: mp+228917@code.qastaging.launchpad.net

Commit message

Re-enable tests for running on device

Description of the change

Add account-plugin-evernote-sandbox as depends for autopilot tests, re-enable testcases

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:205
http://91.189.93.70:8080/job/reminders-app-ci/473/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1207
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1207/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/169

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/473/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:206
http://91.189.93.70:8080/job/reminders-app-ci/474/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1213
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1213/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/170

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/474/rebuild

review: Approve (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

tests are failing on my desktop, though I guess not really related to this branch ?

http://paste.ubuntu.com/7952459/

Revision history for this message
David Planella (dpm) wrote :

Omer, the tests failing might be related to bug 1351041

On Mon, Aug 4, 2014 at 4:48 PM, Omer Akram <email address hidden> wrote:

> tests are failing on my desktop, though I guess not really related to this
> branch ?
>
> http://paste.ubuntu.com/7952459/
> --
> https://code.launchpad.net/~nskaggs/reminders-app/fix-1347905/+merge/228917
> Your team Ubuntu Reminders app developers is requested to review the
> proposed merge of lp:~nskaggs/reminders-app/fix-1347905 into
> lp:reminders-app.
>

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Wow, what timing. Thanks for the link and heads up David.

Revision history for this message
Omer Akram (om26er) wrote :

change looks good.

review: Approve (code)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/231/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1280
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1280/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-autolanding/123

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches