Ubuntu Calculator App

Merge lp://qastaging/~nskaggs/ubuntu-calculator-app/ap-fix-missing-keypress into lp://qastaging/~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

ap-fix-missing-keypress
Merge into old_trunk

Proposed by Nicholas Skaggs on 2014-09-05

Status:

Merged

Approved by:

Nicholas Skaggs on 2014-09-08

Approved revision:

341

Merged at revision:

323

Proposed branch:

lp://qastaging/~nskaggs/ubuntu-calculator-app/ap-fix-missing-keypress

Merge into:

lp://qastaging/~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Diff against target:

1349 lines (+639/-492)

6 files modified

Simple/SimplePage.qml (+1/-0)
tests/autopilot/ubuntu_calculator_app/__init__.py (+332/-7)
tests/autopilot/ubuntu_calculator_app/emulators.py (+0/-282)
tests/autopilot/ubuntu_calculator_app/tests/__init__.py (+156/-72)
tests/autopilot/ubuntu_calculator_app/tests/test_screen.py (+91/-0)
tests/autopilot/ubuntu_calculator_app/tests/test_simple_page.py (+59/-131)

To merge this branch:

bzr merge lp://qastaging/~nskaggs/ubuntu-calculator-app/ap-fix-missing-keypress

Related bugs:

Bug #1316746: Autopilot tests should properly setup environment	Undecided	Fix Released
Bug #1341681: Autopilot tests should stop using deprecated emulators module	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2014-09-08
Leo Arias (community)			Approve on 2014-09-08
Ubuntu Phone Apps Jenkins Bot	continuous-integration	2014-09-05	Approve on 2014-09-08
Review via email: mp+233534@code.qastaging.launchpad.net

Commit message

Increase the keypress duration to avoid missing pressing keys.

Description of the change

A simple tweak to increase the keypress duration to avoid missing pressing keys. We should still consider tweaking how we perform operations.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

FAILED: Continuous integration, rev:322
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/242/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1909
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1909/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/37

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/242/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

PASSED: Continuous integration, rev:324
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/243/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1910
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1910/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/38

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/243/rebuild

review: Approve (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

PASSED: Continuous integration, rev:325
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/244/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1911
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1911/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/39

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/244/rebuild

review: Approve (continuous-integration)

Revision history for this message

Leo Arias (elopio) on 2014-09-05:

#

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-09-05:

#

Thanks Leo, left my replies. I'm really trying to not go overboard on redoing this, but it's easy to start that direction.

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-09-05:

#

All the tests now pass locally and on the device, albeit with the extra attempt. Now to track down why the app isn't capturing the press.

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-09-05:

#

Note, althought some things are converted and some cleanups done, I attempted to keep this as simple as possible. Another MP can bring this inline with current best practices.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

FAILED: Continuous integration, rev:334
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/245/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1912
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1912/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/40

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/245/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

FAILED: Continuous integration, rev:335
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/246/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1913
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1913/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/41

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/246/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

FAILED: Continuous integration, rev:337
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/247/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1914
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1914/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/42

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/247/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

FAILED: Continuous integration, rev:339
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/248/
Executed test runs:
None: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1915/console
SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/43

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/248/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-05:

#

PASSED: Continuous integration, rev:340
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/249/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1916
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1916/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/44

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/249/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-calculator-app-autolanding/32/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/360/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-calculator-app-utopic-amd64-autolanding/30
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/499/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/564
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12774

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-05:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-calculator-app-autolanding/33/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/361/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-calculator-app-utopic-amd64-autolanding/31
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/500/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/565
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12777

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-08:

#

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-calculator-app-autolanding/35/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/366/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-calculator-app-utopic-amd64-autolanding/33
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/505/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/573
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12872

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-09-08:

#

228 + self.pointing_device.press()
229 + buttonarea.pressed.wait_for(True)
230 + self.pointing_device.release()

Could you please put a comment there explaining why calling self.pointing_device.click_object does not work on this case?

lp://qastaging/~nskaggs/ubuntu-calculator-app/ap-fix-missing-keypress updated on 2014-09-08

341. By Nicholas Skaggs on 2014-09-08: add comment explaining use of _click_button

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-09-08:

#

PASSED: Continuous integration, rev:341
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/252/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1945
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1945/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-utopic-amd64-ci/47

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/252/rebuild

review: Approve (continuous-integration)

Revision history for this message

Leo Arias (elopio) on 2014-09-08:

#

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) on 2014-09-08:

#

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Bhaumik Shukla

Nicholas Skaggs

Ubuntu Calculator Developers