Merge lp://qastaging/~nskaggs/ubuntu-calendar-app/fix-1359167 into lp://qastaging/ubuntu-calendar-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 456
Merged at revision: 425
Proposed branch: lp://qastaging/~nskaggs/ubuntu-calendar-app/fix-1359167
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 2194 lines (+797/-970)
21 files modified
click/manifest.json.in (+1/-1)
debian/calendar-app-autopilot.install (+0/-1)
debian/control (+4/-3)
tests/autopilot/CMakeLists.txt (+3/-6)
tests/autopilot/address_book_service_testability/__init__.py (+0/-18)
tests/autopilot/address_book_service_testability/data/backend-store-key-file-data.ini (+0/-12)
tests/autopilot/address_book_service_testability/data/vcard.vcf (+0/-7)
tests/autopilot/address_book_service_testability/fixture_setup.py (+0/-133)
tests/autopilot/address_book_service_testability/helpers.py (+0/-42)
tests/autopilot/calendar_app/CMakeLists.txt (+8/-0)
tests/autopilot/calendar_app/__init__.py (+637/-1)
tests/autopilot/calendar_app/emulators.py (+0/-621)
tests/autopilot/calendar_app/tests/CMakeLists.txt (+6/-0)
tests/autopilot/calendar_app/tests/__init__.py (+37/-17)
tests/autopilot/calendar_app/tests/test_custom_proxy_objects.py (+4/-13)
tests/autopilot/calendar_app/tests/test_dayview.py (+10/-12)
tests/autopilot/calendar_app/tests/test_monthview.py (+10/-12)
tests/autopilot/calendar_app/tests/test_new_event.py (+42/-39)
tests/autopilot/calendar_app/tests/test_weekview.py (+16/-17)
tests/autopilot/calendar_app/tests/test_yearview.py (+13/-15)
tests/autopilot/calendar_app/vcard.vcf (+6/-0)
To merge this branch: bzr merge lp://qastaging/~nskaggs/ubuntu-calendar-app/fix-1359167
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Approve
Review via email: mp+233387@code.qastaging.launchpad.net

Commit message

Update launching, fix bug 1359167, remove packing address_book_service_testability modules, fix _get_selected_day_event_bubbles, add test_new_event_must_start_with_default_values

Description of the change

Update launching, fix bug 1359167, remove packing address_book_service_testability modules, fix _get_selected_day_event_bubbles, add test_new_event_must_start_with_default_values

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

There is something wrong with a new test you've added,
rest works fine on my machine.

Traceback (most recent call last):
  File "/home/mihir/Documents/reviews/fix-1359167/tests/autopilot/calendar_app/tests/test_new_event.py", line 99, in test_new_event_must_start_with_default_values
    self.assertThat(new_event_page.get_calendar(), Equals('Personal'))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = 'Personal'
actual = <ubuntuuitoolkit._custom_proxy_objects._optionselector.OptionSelector object at 0x7f72853b27f0>

Ran 25 tests in 530.692s
FAILED (failures=1)

review: Needs Fixing
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Balloons , thanks for the quick fix.
All test pass on my machine.
Thanks a lot for your time :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: