Merge lp://qastaging/~nskaggs/ubuntu-clock-app/remove-internet-worldclock-unit-test into lp://qastaging/ubuntu-clock-app
Proposed by
Nicholas Skaggs
| Status: | Merged |
|---|---|
| Approved by: | Nicholas Skaggs |
| Approved revision: | 298 |
| Merged at revision: | 297 |
| Proposed branch: | lp://qastaging/~nskaggs/ubuntu-clock-app/remove-internet-worldclock-unit-test |
| Merge into: | lp://qastaging/ubuntu-clock-app |
| Diff against target: |
46 lines (+1/-25) 2 files modified
tests/unit/CMakeLists.txt (+1/-1) tests/unit/tst_worldClock.qml (+0/-24) |
| To merge this branch: | bzr merge lp://qastaging/~nskaggs/ubuntu-clock-app/remove-internet-worldclock-unit-test |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Ubuntu Clock Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Remove test that requires internet inside unit tests
Description of the change
Remove test that requires internet inside unit tests
Launchpad builders can't access the internet. Internet enabled tests should be run at a higher level. Since the base functionality is otherwise tested in the testsuite, this test can be considered redundant and can be removed.
I also changed the screensize to be more inline with a phone.
To post a comment you must log in.
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | # |
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Approving to check launchpad build.