Ubuntu Terminal App

Merge lp://qastaging/~nskaggs/ubuntu-terminal-app/restore-autopilot into lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

restore-autopilot
Merge into reboot

Proposed by Nicholas Skaggs on 2016-03-07

Status:	Merged
Approved by:	Stefano Verzegnassi on 2016-03-08
Approved revision:	193
Merged at revision:	189
Proposed branch:	lp://qastaging/~nskaggs/ubuntu-terminal-app/restore-autopilot
Merge into:	lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target:	798 lines (+258/-482) 9 files modified README.autopilot.md (+74/-0) old-tests/CMakeLists.txt (+0/-1) old-tests/autopilot/CMakeLists.txt (+0/-8) old-tests/autopilot/ubuntu_terminal_app/__init__.py (+0/-174) old-tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+0/-131) old-tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py (+0/-157) tests/autopilot/ubuntu_terminal_app/__init__.py (+23/-1) tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+153/-1) tests/autopilot/ubuntu_terminal_app/tests/test_terminal.py (+8/-9)
To merge this branch:	bzr merge lp://qastaging/~nskaggs/ubuntu-terminal-app/restore-autopilot
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Stefano Verzegnassi		2016-03-07	Approve on 2016-03-08
Jenkins Bot	continuous-integration		Approve on 2016-03-08
Review via email: mp+288347@code.qastaging.launchpad.net

Commit message

Add back templates for autopilot
add autopilot readme

Description of the change

Add back templates for autopilot
add autopilot readme

lp://qastaging/~nskaggs/ubuntu-terminal-app/restore-autopilot updated on 2016-03-07

191. By Nicholas Skaggs on 2016-03-07: undo pot change

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-03-07:

PASSED: Continuous integration, rev:190
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/47/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/712/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/47/rebuild

review: Approve (continuous-integration)

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-03-07:

PASSED: Continuous integration, rev:191
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/48/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/713/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/48/rebuild

review: Approve (continuous-integration)

lp://qastaging/~nskaggs/ubuntu-terminal-app/restore-autopilot updated on 2016-03-07

192. By Nicholas Skaggs on 2016-03-07: typos

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-03-07:

PASSED: Continuous integration, rev:192
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/49/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/716/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/49/rebuild

review: Approve (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2016-03-07:

https://core-apps-jenkins.ubuntu.com/view/Release/job/run-ap-tests-release/11/console

Revision history for this message

Stefano Verzegnassi (verzegnassi-stefano) wrote on 2016-03-08:

Tested on my PC and it works well.
My only question is about Python coding style: should we still refer to the pep8 conventions?

PS. One diff comment included (i.e. music-app typo).

======

$ pep8 ./tests
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:42:80: E501 line too long (94 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:45:80: E501 line too long (90 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:47:80: E501 line too long (89 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:72:80: E501 line too long (80 > 79 characters)
./tests/autopilot/ubuntu_terminal_app/tests/__init__.py:90:5: E303 too many blank lines (2)

review: Needs Information

lp://qastaging/~nskaggs/ubuntu-terminal-app/restore-autopilot updated on 2016-03-08

193. By Nicholas Skaggs on 2016-03-08: flake8 and typo

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2016-03-08:

Absolutely; I fixed things and ran flake8:

flake8 ubuntu_terminal_app/*.py ubuntu_terminal_app/tests/*.py
ubuntu_terminal_app/tests/__init__.py:22:1: E402 module level import not at top of file
ubuntu_terminal_app/tests/__init__.py:38:39: W503 line break before binary operator