Merge lp://qastaging/~oddbloke/livecd-rootfs/trunk into lp://qastaging/livecd-rootfs

Proposed by Dan Watkins
Status: Merged
Merged at revision: 1681
Proposed branch: lp://qastaging/~oddbloke/livecd-rootfs/trunk
Merge into: lp://qastaging/livecd-rootfs
Diff against target: 124 lines (+47/-48)
4 files modified
debian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/031-0-create-root-dir.binary (+26/-0)
live-build/ubuntu-cpc/hooks/031-1-root-xz.binary (+5/-19)
live-build/ubuntu-cpc/hooks/031-2-root-squashfs.binary (+9/-29)
To merge this branch: bzr merge lp://qastaging/~oddbloke/livecd-rootfs/trunk
Reviewer Review Type Date Requested Status
Adam Conrad (community) Approve
Robert C Jennings (community) Approve
Philip Roche (community) Approve
Review via email: mp+347628@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Philip Roche (philroche) :
review: Approve
Revision history for this message
Robert C Jennings (rcj) wrote :

+1

review: Approve
Revision history for this message
Adam Conrad (adconrad) wrote :

A few inline comments, but mostly +1ish. Respond with either code or words, and we're good to go.

Revision history for this message
Dan Watkins (oddbloke) wrote :

Thanks for the review, those were all bits I missed. I have responded
with code.

Revision history for this message
Adam Conrad (adconrad) wrote :

LGTM, merging and uploading.

review: Approve
1681. By Adam Conrad

ubuntu-cpc: Generate the root image contents once, and use it for both the
-root.tar.xz and the .squashfs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches