Provider for Plainbox - PC Sanity

Merge plainbox-provider-pc-sanity:boot-up-time-check into plainbox-provider-pc-sanity:master

  1. Git
  2. lp:plainbox-provider-pc-sanity
  3. boot-up-time-check
  4. Merge into master
Proposed by Artur Pak
Status: Merged
Approved by: Kai-Chuan Hsieh
Approved revision: a988d4ffc90dc3f09f62c9c67931cd5b66edbd12
Merged at revision: 2c13ef76afab63b88546cace64e762468743e381
Proposed branch: plainbox-provider-pc-sanity:boot-up-time-check
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 76 lines (+44/-0)
3 files modified
bin/boot-up-time-check.sh (+27/-0)
units/pc-sanity/pc-sanity-misc.pxu (+15/-0)
units/pc-sanity/pc-sanity.pxu (+2/-0)
Reviewer Review Type Date Requested Status
Kai-Chuan Hsieh Approve
Andy Chi Pending
Review via email: mp+454847@code.qastaging.launchpad.net

Commit message

added test case to measure the system boot up time

To post a comment you must log in.
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Please see my comment.

Revision history for this message
jeremyszu (os369510) wrote :

Do we consider to submit this to checkbox?

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

> Do we consider to submit this to checkbox?

I think it is yes, but we need to specify pass criteria for different form factor.

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

@artur

You can link the MP to the bug, it is easier to review why you create the test job.

Revision history for this message
Artur Pak (artur-at-work) wrote :

> Please see my comment.

Thank you. I've added gdm3 check and other advises.

Revision history for this message
Artur Pak (artur-at-work) wrote (last edit ):

As discussed,
- specified laptops/notebooks, because expected boot up time can be different for other form factors.
- checking for gdm3 to expect that login screen has loaded
- added output when failed

Please help to review again.

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Please see my comment below.

Revision history for this message
Artur Pak (artur-at-work) wrote :

@KC, thanks, I have added the graphical.target check.
Please help to review.

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

LGTM

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches