Merge lp://qastaging/~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing into lp://qastaging/openerp-canada

Proposed by Vincent Vinet
Status: Merged
Approved by: Maxime Chambreuil (http://www.savoirfairelinux.com)
Approved revision: no longer in the source branch.
Merged at revision: 27
Proposed branch: lp://qastaging/~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing
Merge into: lp://qastaging/openerp-canada
Diff against target: 89 lines (+14/-9)
4 files modified
l10n_ca_account_check_writing/account_voucher.py (+2/-2)
l10n_ca_account_check_writing/report/l10n_ca_check_print.py (+8/-3)
l10n_ca_account_check_writing/report/l10n_ca_check_print_middle.rml (+2/-2)
l10n_ca_account_check_writing/report/l10n_ca_check_print_top.rml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing
Reviewer Review Type Date Requested Status
Sandy Carter (http://www.savoirfairelinux.com) Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) Approve
Review via email: mp+216708@code.qastaging.launchpad.net

Description of the change

Modify the l10n_ca_account_check_writing module pdf reports to also
show credit lines for a voucher.

Also fix a str being used instead of unicode to format data from a model, which
caused errors with accents in account lines.

To post a comment you must log in.
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

LGTM, thanks

The future module is worth looking at for future.str_as_unicode

https://pypi.python.org/pypi/future/0.3.1

review: Approve
27. By Vincent Vinet

[MRG] Show credit and debit lines when printing checks

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches