Odoo Addons (MOVED TO GITHUB)

Merge lp://qastaging/~openerp-community/openobject-addons/fix-account-trunk-tax-computation-method into lp://qastaging/openobject-addons

fix-account-trunk-tax-computation-method
Merge into trunk

Proposed by Lorenzo Battistini on 2012-05-07

Status:

Needs review

Proposed branch:

lp://qastaging/~openerp-community/openobject-addons/fix-account-trunk-tax-computation-method

Merge into:

lp://qastaging/openobject-addons

Diff against target:

1101 lines (+803/-15)

14 files modified

account/__openerp__.py (+2/-0)
account/account.py (+21/-0)
account/account_invoice.py (+62/-5)
account/account_invoice_view.xml (+2/-0)
account/demo/account_tax.xml (+68/-0)
account/test/tax_computation.yml (+471/-0)
purchase/__openerp__.py (+1/-0)
purchase/purchase.py (+21/-4)
purchase/purchase_view.xml (+1/-0)
purchase/test/tax_computation.yml (+67/-0)
sale/__openerp__.py (+1/-0)
sale/sale.py (+20/-6)
sale/sale_view.xml (+1/-0)
sale/test/tax_computation.yml (+65/-0)

To merge this branch:

bzr merge lp://qastaging/~openerp-community/openobject-addons/fix-account-trunk-tax-computation-method

Wishlist

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Fabien (Open ERP)	2012-05-07	Disapprove on 2012-05-08
Olivier Dony (Odoo)	2012-05-10	Pending
Review via email: mp+104945@code.qastaging.launchpad.net

Description of the change

These changes add the possibility to perform the tax computation "by column" in invoices, sale orders and purchase orders. Currently, a boolean field 'Tax Computation By Column' is added to each of these models, allowing the user to choose which computation method to use.

References:
https://bugs.launchpad.net/openobject-addons/+bug/707923
http://feedback.openerp.com/forums/77459-general-improvements/suggestions/1449257-solve-invoice-tax-rounding-issue
https://docs.google.com/document/d/1hZpHSmWyQ74Fa7jilYxaxX5QE47C6fCIk4DWBlsMYwg/edit

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2012-05-08:

This solution is too complex. I already did it months ago and I remember it's just 10 lines of code on the tax object (that should depend on a configuration on the company).

review: Disapprove

Revision history for this message

Davide Corio (enlightx-deactivatedaccount) wrote on 2012-05-08:

Is this something already integrated in 6.1?
i cannot find it

btw, this cannot be a global (per company) configuration because the user must be able to select the correct vat computation method on the document.

we usually receive invoices and sale orders computed by row from USA and by column from France, for instance.

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2012-05-08:

On 05/08/2012 02:44 PM, Fabien (Open ERP) wrote:
> Review: Disapprove
>
> This solution is too complex. I already did it months ago and I remember it's just 10 lines of code on the tax object (that should depend on a configuration on the company).

Hi Fabien,

if this is already fixed then that is good news. We were hit by this
issue a number of times and were pleased to see Lorenzo's effort to get
this in the core code (we used his module to the same effect until now).
Can you point to the revision or at least the lines in the code in which
you fixed this?

Cheers,
Stefan.

--
Therp - Maatwerk in open ontwikkeling

Stefan Rijnhart - Ontwerp en implementatie

mail: <email address hidden>
tel: +31 (0) 614478606
http://therp.nl
https://twitter.com/therp_stefan