OpenERP Documentation

Merge lp://qastaging/~openerp-community/openobject-doc/mgmtsystem into lp://qastaging/~openerp-community/openobject-doc/6.0

mgmtsystem
Merge into 6.0

Proposed by Maxime Chambreuil (http://www.savoirfairelinux.com) on 2011-03-15

Status:	Superseded
Proposed branch:	lp://qastaging/~openerp-community/openobject-doc/mgmtsystem
Merge into:	lp://qastaging/~openerp-community/openobject-doc/6.0
Diff against target:	363 lines (+314/-0) 6 files modified source/book/7/7_23_Managementsystem/7_23_Managementsystem_action.rst (+62/-0) source/book/7/7_23_Managementsystem/7_23_Managementsystem_audit.rst (+61/-0) source/book/7/7_23_Managementsystem/7_23_Managementsystem_manual.rst (+69/-0) source/book/7/7_23_Managementsystem/7_23_Managementsystem_nonconformity.rst (+62/-0) source/book/7/7_23_Managementsystem/index.rst (+59/-0) source/book/7/index.rst (+1/-0)
To merge this branch:	bzr merge lp://qastaging/~openerp-community/openobject-doc/mgmtsystem
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Don Kirkby	2011-03-15	Needs Fixing on 2011-03-15
Maxime Chambreuil (http://www.savoirfairelinux.com)		Approve on 2011-03-15
Els Van Vossel (Foxy)	2011-03-15	Pending
Review via email: mp+53440@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-03-14.

This proposal has been superseded by a proposal from 2011-03-15.

Description of the change

[ADD] Management system

Revision history for this message

Don Kirkby (donkirkby) wrote on 2011-03-14: Posted in a previous version of this proposal

Hi Maxime,
Thanks for the contribution, I noticed a few minor problems that should be cleaned up, along with a question:
1. /mnt/workspace/don/openerp-bzr/doc2/6.0/source/book/7/7_23_Managementsystem/7_23_Managementsystem_action.rst:28: (WARNING/2) Block quote ends without a blank line; unexpected unindent.
2. /mnt/workspace/don/openerp-bzr/doc2/6.0/source/book/7/7_23_Managementsystem/7_23_Managementsystem_action.rst:30: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
3. Link to mgmtsystem_environment module has a typo.
4. Why do you hide the table of contents on the index page?

yours,
Don

review: Needs Fixing

Revision history for this message

Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote on 2011-03-15: Posted in a previous version of this proposal

Hi Don,

> 1. /mnt/workspace/don/openerp-bzr/doc2/6.0/source/book/7/7_23_Managementsystem
> /7_23_Managementsystem_action.rst:28: (WARNING/2) Block quote ends without a
> blank line; unexpected unindent.

Fixed.

> 2. /mnt/workspace/don/openerp-bzr/doc2/6.0/source/book/7/7_23_Managementsystem
> /7_23_Managementsystem_action.rst:30: (WARNING/2) Definition list ends without
> a blank line; unexpected unindent.

Fixed.

> 3. Link to mgmtsystem_environment module has a typo.

Fixed.

> 4. Why do you hide the table of contents on the index page?

I did the same as the Document Management chapter.

review: Needs Resubmitting

Revision history for this message

Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) on 2011-03-15:

review: Approve

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2011-03-15:

Maxime, I also asked Els (~evv-openerp) to review your proposal, as she is ultimately responsible for the book content, structure, etc.
From a technical point of view, this look good to me, at revision 771.

Revision history for this message

Don Kirkby (donkirkby) wrote on 2011-03-15:

All the other problems seem fixed, but there's a new one:

/mnt/workspace/don/openerp-bzr/doc2/6.0/source/book/7/7_23_Managementsystem/index.rst:10: (WARNING/2) Inline emphasis start-string without end-string.