OpenERP India

Merge lp://qastaging/~openerp-dev/openerp-india/payroll-india-trunk-payment-advice-kbh into lp://qastaging/~openerp-dev/openerp-india/payroll-india-trunk

payroll-india-trunk-payment-advice-kbh
Merge into payroll-india-trunk

Proposed by Khushboo Bhatt(openerp) on 2012-06-04

Status:	Superseded
Proposed branch:	lp://qastaging/~openerp-dev/openerp-india/payroll-india-trunk-payment-advice-kbh
Merge into:	lp://qastaging/~openerp-dev/openerp-india/payroll-india-trunk
Diff against target:	267 lines (+197/-3) 6 files modified l10n_in_hr_payroll/__openerp__.py (+1/-0) l10n_in_hr_payroll/l10n_in_hr_payroll.py (+107/-1) l10n_in_hr_payroll/l10n_in_hr_payroll_data.xml (+1/-1) l10n_in_hr_payroll/l10n_in_hr_payroll_demo.xml (+1/-1) l10n_in_hr_payroll/l10n_in_hr_payroll_sequence.xml (+15/-0) l10n_in_hr_payroll/l10n_in_hr_payroll_view.xml (+72/-0)
To merge this branch:	bzr merge lp://qastaging/~openerp-dev/openerp-india/payroll-india-trunk-payment-advice-kbh
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Mustufa Rangwala (Open ERP)		2012-06-04	Needs Fixing on 2012-06-05
Review via email: mp+108561@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-06-06.

Description of the change

Hello,

===l10n_in_hr_payroll===

Added objects and view of payment advice and advice lines.

Thank you,
KBH.

Revision history for this message

Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote on 2012-06-05:

Hello khusboo,

During the testing of your branch, I found some issues listed below.

- While creating new db: No such external ID currently defined in the system: l10n_in_hr_payroll.hr_payroll_rule_child_edu
- Position of button on advice form is not proper + improve workflow
- You can get only current month payslips if I try to compute advice without payslip
- If I cancel the advice and recomput the advice again it create duplicate advice lines.
- Without bank compute advice not working
- remove amount from advice line

Thanks,
Mustufa

review: Needs Fixing

Revision history for this message

Khushboo Bhatt(openerp) (kbh-openerp) wrote on 2012-06-06:

Hello,

Changes are done as per suggestion.

Thank you,
KBH.

> Hello khusboo,
>
> During the testing of your branch, I found some issues listed below.
>
> - While creating new db: No such external ID currently defined in the system:
> l10n_in_hr_payroll.hr_payroll_rule_child_edu
> - Position of button on advice form is not proper + improve workflow
> - You can get only current month payslips if I try to compute advice without
> payslip
> - If I cancel the advice and recomput the advice again it create duplicate
> advice lines.
> - Without bank compute advice not working
> - remove amount from advice line
>
> Thanks,
> Mustufa