Merge lp://qastaging/~openerp-dev/openobject-addons/6.0-bug-783496-pso into lp://qastaging/openobject-addons/6.0

Proposed by Priyesh (OpenERP)
Status: Needs review
Proposed branch: lp://qastaging/~openerp-dev/openobject-addons/6.0-bug-783496-pso
Merge into: lp://qastaging/openobject-addons/6.0
Diff against target: 233 lines (+66/-44)
3 files modified
account_voucher/account_voucher.py (+48/-26)
account_voucher/voucher_payment_receipt_view.xml (+14/-14)
account_voucher/voucher_sales_purchase_view.xml (+4/-4)
To merge this branch: bzr merge lp://qastaging/~openerp-dev/openobject-addons/6.0-bug-783496-pso
Reviewer Review Type Date Requested Status
Thomas Winteler (Win-Soft) (community) Approve
Leonardo Pistone (community) Approve
qdp (OpenERP) Pending
Olivier Dony (Odoo) Pending
OpenERP Core Team Pending
Review via email: mp+61917@code.qastaging.launchpad.net

Description of the change

Hello,

Fixed https://bugs.launchpad.net/openobject-addons/+bug/783496
Improved onchange_partner_id method of voucher
Passed voucher lines in onchange_partner_id method

Thanks,
pso

To post a comment you must log in.
Revision history for this message
Leonardo Pistone (lepistone) wrote :

We tested this with a clone of the DB from our customer that made the OPW request. It seems OK to us.

Thanks!

review: Approve
Revision history for this message
Thomas Winteler (Win-Soft) (thomi) wrote :

As Leonardo writes, we have tested that on customers instance and it worked as it should. Only one thing maybe should be handled as a enhancement ;)
See my comment: https://bugs.launchpad.net/openobject-addons/+bug/783496/comments/6

review: Approve
Revision history for this message
Priyesh (OpenERP) (pso-openerp) wrote :

Leonardo and Thomas,

Thanks for the feedback.

We are investing more for a best suitable approach as a fix.

However, the enhancement you listed here is not really a blocking one.

Thanks.

Unmerged revisions

4590. By Priyesh (OpenERP)

[FIX] account_voucher: Onchange of amount removes all manually added lines

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.