Merge lp://qastaging/~openerp-dev/openobject-server/trunk-addons_issue16_image-mma into lp://qastaging/openobject-server

Proposed by Mayur Maheshwari(OpenERP)
Status: Needs review
Proposed branch: lp://qastaging/~openerp-dev/openobject-server/trunk-addons_issue16_image-mma
Merge into: lp://qastaging/openobject-server
Diff against target: 628 lines (+311/-280)
4 files modified
openerp/addons/base/__openerp__.py (+0/-1)
openerp/addons/base/res/res_company.py (+1/-1)
openerp/addons/base/res/res_partner_demo.xml (+310/-0)
openerp/addons/base/res/res_partner_demo.yml (+0/-278)
To merge this branch: bzr merge lp://qastaging/~openerp-dev/openobject-server/trunk-addons_issue16_image-mma
Reviewer Review Type Date Requested Status
Rucha (Open ERP) (community) Disapprove
DJ Patel (OpenERP) (community) Approve
Review via email: mp+131858@code.qastaging.launchpad.net

Description of the change

Hello

   I Have fix the issue of at the time of creation of record, it will override the actual image by default image

Thanks
Mayur

To post a comment you must log in.
Revision history for this message
DJ Patel (OpenERP) (mdi-openerp) wrote :

It seems ok.

Thanks,
Divyesh

review: Approve
Revision history for this message
DJ Patel (OpenERP) (mdi-openerp) wrote :

At the time of creation of record, the on-change will fire and it will override the actual image by default image.

If we remove the call to set default image inside on-change, then it works fine, but due to that, the functionality to change the image(image for company or image for a contact) inside on-change is totally disappeared.

Revision history for this message
Rucha (Open ERP) (rpa-openerp) wrote :

not a good solution, this way now we don't get address values from company, the goal to add yml file for contact was to fire onchange,
(see discussion on https://code.launchpad.net/~openerp-dev/openobject-server/trunk-improve-demo-rpa/+merge/115123)
Please find another way,

Thanks

review: Disapprove

Unmerged revisions

4515. By DJ Patel (OpenERP)

[Merge] Merge the branch : lp:~openerp-dev/openobject-server/trunk-res_partner_demo-cha.

4514. By Mayur Maheshwari(OpenERP)

[IMP]base : fix the image issue

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.