Odoo Server (MOVED TO GITHUB)

Merge lp://qastaging/~openerp-dev/openobject-server/trunk-test-al into lp://qastaging/openobject-server

  1. trunk-test-al
  2. Merge into trunk
Proposed by Antony Lesuisse (OpenERP)
Status: Work in progress
Proposed branch: lp://qastaging/~openerp-dev/openobject-server/trunk-test-al
Merge into: lp://qastaging/openobject-server
Diff against target: 1685 lines (+478/-589)
34 files modified
openerp/addons/__init__.py (+0/-3)
openerp/addons/base/__openerp__.py (+0/-2)
openerp/addons/base/test/bug_lp541545.xml (+0/-14)
openerp/addons/base/test/test_context.xml (+0/-20)
openerp/addons/base/tests/__init__.py (+16/-12)
openerp/addons/base/tests/test_acl.py (+1/-2)
openerp/addons/base/tests/test_basecase.py (+1/-1)
openerp/addons/base/tests/test_db_cursor.py (+1/-1)
openerp/addons/base/tests/test_expression.py (+10/-1)
openerp/addons/base/tests/test_fields.py (+1/-2)
openerp/addons/base/tests/test_ir_filters.py (+1/-1)
openerp/addons/base/tests/test_ir_sequence.py (+1/-1)
openerp/addons/base/tests/test_mail.py (+2/-1)
openerp/addons/base/tests/test_misc.py (+37/-0)
openerp/addons/base/tests/test_orm.py (+1/-1)
openerp/addons/base/tests/test_phantom.py (+11/-0)
openerp/addons/base/tests/test_phantom_dummy.js (+4/-0)
openerp/addons/base/tests/test_uninstall.py (+89/-0)
openerp/addons/base/tests/test_xmlrpc.py (+12/-54)
openerp/cli/server.py (+10/-26)
openerp/http.py (+5/-2)
openerp/modules/__init__.py (+3/-9)
openerp/modules/loading.py (+4/-11)
openerp/modules/module.py (+65/-216)
openerp/modules/registry.py (+48/-57)
openerp/service/model.py (+0/-2)
openerp/service/server.py (+36/-7)
openerp/sql_db.py (+3/-0)
openerp/tests/__init__.py (+5/-39)
openerp/tests/common.py (+108/-45)
openerp/tests/test_expression.py (+0/-13)
openerp/tests/test_misc.py (+0/-44)
openerp/tools/yaml_import.py (+1/-2)
openerpcommand/run_tests.py (+2/-0)
To merge this branch: bzr merge lp://qastaging/~openerp-dev/openobject-server/trunk-test-al
Reviewer Review Type Date Requested Status
Christophe Simonis (OpenERP) Needs Fixing
Raphael Collet (OpenERP) (community) Needs Information
Review via email: mp+202225@code.qastaging.launchpad.net
To post a comment you must log in.
lp://qastaging/~openerp-dev/openobject-server/trunk-test-al updated
5018. By Antony Lesuisse (OpenERP)

replace RpcTestCase by HttpTestCase
- postponed when the server is listening
- magic session_id for cross requests rollback

5019. By Antony Lesuisse (OpenERP)

[MERGE] trunk

5020. By Antony Lesuisse (OpenERP)

add phantomjs helper for HttpCase (refactored from ddm website test)

5021. By Antony Lesuisse (OpenERP)

[MERGE] trunk

5022. By Antony Lesuisse (OpenERP)

[FIX] merge conflicts woes

5023. By Antony Lesuisse (OpenERP)

[IMP] start http before preloading regsitries

5024. By Antony Lesuisse (OpenERP)

[IMP] run http test, dont lock the registry manager

5025. By Antony Lesuisse (OpenERP)

[IMP] allow request registries under construction

5026. By Antony Lesuisse (OpenERP)

[FIX] oe run_test return code 0

5027. By Antony Lesuisse (OpenERP)

[ADD] phantomjs example test

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Why have you removed openerp/addons/base/test/bug_lp541545.xml ?
I suppose it was there for a good reason...

review: Needs Information
Reply
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Please redo the move openerp/tests/test_misc.py -> openerp/addons/base/tests/test_misc.py with "bzr mv".
You've screwed up the file history.

review: Needs Fixing
Reply
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Why have you removed the lock from the registry?
Couldn't this cause an issue when the server runs multi-threaded?

review: Needs Information
Reply
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Please remove commented code (diff 1332-1335).

Reply
Revision history for this message
Christophe Simonis (OpenERP) (kangol) wrote :

> Please redo the move openerp/tests/test_misc.py ->
> openerp/addons/base/tests/test_misc.py with "bzr mv".
> You've screwed up the file history.

same for openerp/addons/base/tests/test_uninstall.py and openerp/tests/test_expression.py

review: Needs Fixing
Reply
Revision history for this message
Christophe Simonis (OpenERP) (kangol) wrote :

Why removing the RLock on registry access?

The check on _init (openerp/service/model.py) was there for a good reason. do not remove it.
Accessing the database during loading may lead to strange things for the end-user. I know it's needed to http test but only deactivate this behaviour if the server is running with --test-enable flag.

review: Needs Fixing
Reply

Unmerged revisions

5027. By Antony Lesuisse (OpenERP)

[ADD] phantomjs example test

5026. By Antony Lesuisse (OpenERP)

[FIX] oe run_test return code 0

5025. By Antony Lesuisse (OpenERP)

[IMP] allow request registries under construction

5024. By Antony Lesuisse (OpenERP)

[IMP] run http test, dont lock the registry manager

5023. By Antony Lesuisse (OpenERP)

[IMP] start http before preloading regsitries

5022. By Antony Lesuisse (OpenERP)

[FIX] merge conflicts woes

5021. By Antony Lesuisse (OpenERP)

[MERGE] trunk

5020. By Antony Lesuisse (OpenERP)

add phantomjs helper for HttpCase (refactored from ddm website test)

5019. By Antony Lesuisse (OpenERP)

[MERGE] trunk

5018. By Antony Lesuisse (OpenERP)

replace RpcTestCase by HttpTestCase
- postponed when the server is listening
- magic session_id for cross requests rollback

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.