OpenERP Italia

Merge lp://qastaging/~openobject-italia-core-devs/openobject-italia/7.0-l10n_it_sale-pep8 into lp://qastaging/~openobject-italia-core-devs/openobject-italia/italian-addons-7.0

  1. 7.0-l10n_it_sale-pep8
  2. Merge into italian-addons-7.0
Proposed by Davide Corio
Status: Needs review
Proposed branch: lp://qastaging/~openobject-italia-core-devs/openobject-italia/7.0-l10n_it_sale-pep8
Merge into: lp://qastaging/~openobject-italia-core-devs/openobject-italia/italian-addons-7.0
Diff against target: 515 lines (+144/-107)
12 files modified
l10n_it_sale/__init__.py (+2/-2)
l10n_it_sale/__openerp__.py (+5/-8)
l10n_it_sale/account/__init__.py (+2/-3)
l10n_it_sale/account/invoice.py (+28/-20)
l10n_it_sale/partner/__init__.py (+1/-1)
l10n_it_sale/partner/partner.py (+10/-7)
l10n_it_sale/sale/__init__.py (+1/-2)
l10n_it_sale/sale/sale.py (+28/-22)
l10n_it_sale/stock/__init__.py (+1/-3)
l10n_it_sale/stock/picking.py (+57/-32)
l10n_it_sale/wizard/__init__.py (+1/-1)
l10n_it_sale/wizard/assign_ddt.py (+8/-6)
To merge this branch: bzr merge lp://qastaging/~openobject-italia-core-devs/openobject-italia/7.0-l10n_it_sale-pep8
Reviewer Review Type Date Requested Status
Leonardo Pistone (community) Needs Fixing
Andrea Cometa (community) Approve
andrea_cg (community) Approve
Review via email: mp+220483@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

ho escluso F401, siccome mi era parso di leggere che si preferisce tollerare il controllo piuttosto che riempire il codice di assert

Reply
Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

aggiungo che ho dovuto creare qualche variabile in più con nomi abbreviati per rimanere nelle 79 cols

Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

Se preferisci

http://pastie.org/9196360
può diventare ad esempio
http://pastie.org/9196367

E
http://pastie.org/9196370
può diventare
http://pastie.org/9196375

Discorso simile per picking.py

Reply
Revision history for this message
Leonardo Pistone (lepistone) wrote :

+1 Lorenzo

Reply
Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

Non ci avrei mai pensato da solo...

+1

Reply
lp://qastaging/~openobject-italia-core-devs/openobject-italia/7.0-l10n_it_sale-pep8 updated
241. By Davide Corio

[IMP] code cleanup

242. By Davide Corio

[IMP] code cleanup

243. By Davide Corio

[IMP] code cleanup

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Grazie Davide.

Ah, solo un'altra cosa: riga 157 come mai hai tolto lo spazio?

Reply
lp://qastaging/~openobject-italia-core-devs/openobject-italia/7.0-l10n_it_sale-pep8 updated
244. By Davide Corio

[FIX] missing space

Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

Umh... non te lo so dire :)

rimesso spazio

Reply
Revision history for this message
andrea_cg (a-gallina) wrote :

+1

review: Approve
Reply
Revision history for this message
Andrea Cometa (scigghia) wrote :

+8 :)

review: Approve
Reply
Revision history for this message
Leonardo Pistone (lepistone) wrote :

l'F401 possiamo ignorarlo solo negli __init__.py. Ci sono altri import inutili che sono davvero inutili.

o in alternativa, non lo ignoriamo del tutto e mettiamo # noqa negli import di __init__.py.

ciao

review: Needs Fixing
Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

This project is now hosted on https://github.com/OCA/l10n-italy. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Reply

Unmerged revisions

244. By Davide Corio

[FIX] missing space

243. By Davide Corio

[IMP] code cleanup

242. By Davide Corio

[IMP] code cleanup

241. By Davide Corio

[IMP] code cleanup

240. By Davide Corio

[IMP] pep8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches