Merge lp://qastaging/~openstack-charmers/charms/trusty/nova-compute/0mq into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#695 nova-compute-next for gnuoy mp238879
charm_lint_check

This build:
http://10.98.191.181:8080/job/charm_lint_check/695/

MP URL:
https://code.launchpad.net/~openstack-charmers/charms/trusty/nova-compute/0mq/+merge/238879

Proposed branch:
lp:~openstack-charmers/charms/trusty/nova-compute/0mq

Results summary:
    LINT FAIL: lint-check failed

LINT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.695:
hooks/nova_compute_utils.py:93:1: E101 indentation contains mixed spaces and tabs
hooks/nova_compute_utils.py:93:1: W191 indentation contains tabs
hooks/nova_compute_utils.py:93:8: E128 continuation line under-indented for visual indent
make: *** [lint] Error 1

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#501 nova-compute-next for gnuoy mp238879
charm_unit_test

This build:
http://10.98.191.181:8080/job/charm_unit_test/501/

MP URL:
https://code.launchpad.net/~openstack-charmers/charms/trusty/nova-compute/0mq/+merge/238879

Proposed branch:
lp:~openstack-charmers/charms/trusty/nova-compute/0mq

Results summary:
    UNIT FAIL: unit-test failed

UNIT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.501:
    get_os_codename_install_source(config('openstack-origin')) or
  File "hooks/charmhelpers/core/hookenv.py", line 44, in wrapper
    res = func(*args, **kwargs)
  File "hooks/charmhelpers/core/hookenv.py", line 281, in config
    config_data = json.loads(subprocess.check_output(config_cmd_line))
  File "/usr/lib/python2.7/subprocess.py", line 566, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Name Stmts Miss Cover Missing
----------------------------------------------------
nova_compute_context 204 70 66% 34-37, 42-43, 61, 65-66, 71, 97, 101, 104, 113, 119-131, 172, 203, 227-229, 241, 256-259, 263-266, 269-272, 293, 320-328, 331-349, 357, 361, 365, 368-370, 376-385
nova_compute_hooks 141 15 89% 81, 99-100, 128, 194, 252, 257-258, 264, 270, 278, 282-285
nova_compute_utils 230 111 52% 163-219, 227, 232-235, 270-272, 279, 283-286, 294-302, 306, 315-324, 337-356, 382-383, 387-388, 407-428, 445-455, 469-470, 474, 479-480
----------------------------------------------------
TOTAL 575 196 66%
----------------------------------------------------------------------
Ran 56 tests in 7.145s

FAILED (SKIP=5, errors=3)
make: *** [unit_test] Error 1

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#703 nova-compute-next for gnuoy mp238879
charm_lint_check

This build:
http://10.98.191.181:8080/job/charm_lint_check/703/

MP URL:
https://code.launchpad.net/~openstack-charmers/charms/trusty/nova-compute/0mq/+merge/238879

Proposed branch:
lp:~openstack-charmers/charms/trusty/nova-compute/0mq

Results summary:
    LINT OK: believed to pass, but you should confirm results

LINT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.703:
W: no README file
I: relation neutron-plugin has no hooks
I: missing recommended hook start
I: missing recommended hook stop
I: config.yaml: option os-data-network has no default value
I: config.yaml: option config-flags has no default value
I: config.yaml: option instances-path has no default value
W: config.yaml: option disable-neutron-security-groups has no default value
I: config.yaml: option migration-auth-type has no default value

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#509 nova-compute-next for gnuoy mp238879
charm_unit_test

This build:
http://10.98.191.181:8080/job/charm_unit_test/509/

MP URL:
https://code.launchpad.net/~openstack-charmers/charms/trusty/nova-compute/0mq/+merge/238879

Proposed branch:
lp:~openstack-charmers/charms/trusty/nova-compute/0mq

Results summary:
    UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.509:
Starting unit tests...
......S.............................................SSSS
Name Stmts Miss Cover Missing
----------------------------------------------------
nova_compute_context 204 70 66% 34-37, 42-43, 61, 65-66, 71, 97, 101, 104, 113, 119-131, 172, 203, 227-229, 241, 256-259, 263-266, 269-272, 293, 320-328, 331-349, 357, 361, 365, 368-370, 376-385
nova_compute_hooks 141 15 89% 81, 99-100, 128, 194, 252, 257-258, 264, 270, 278, 282-285
nova_compute_utils 230 111 52% 163-219, 227, 232-235, 270-272, 279, 283-286, 294-302, 306, 315-324, 337-356, 382-383, 387-388, 407-428, 445-455, 469-470, 474, 479-480
----------------------------------------------------
TOTAL 575 196 66%
----------------------------------------------------------------------
Ran 56 tests in 2.899s

OK (SKIP=5)

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/

Removed superfluous stopstart=True from 0mq config restart_on_change decorator as James suggested in inline comment

UOSCI bot says:
charm_lint_check #736 nova-compute-next for gnuoy mp238879
    LINT OK: believed to pass, but you should confirm results

LINT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.736:
I: config.yaml: option config-flags has no default value
I: config.yaml: option instances-path has no default value
W: config.yaml: option disable-neutron-security-groups has no default value
I: config.yaml: option migration-auth-type has no default value

Full lint output: http://paste.ubuntu.com/8638295/
Build: http://10.98.191.181:8080/job/charm_lint_check/736/

UOSCI bot says:
charm_unit_test #544 nova-compute-next for gnuoy mp238879
    UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.544:
----------------------------------------------------------------------
Ran 56 tests in 2.752s

OK (SKIP=5)

Full unit output: http://paste.ubuntu.com/8638296/
Build: http://10.98.191.181:8080/job/charm_unit_test/544/

UOSCI bot says:
charm_amulet_test #289 nova-compute-next for gnuoy mp238879
    AMULET OK: believed to pass, but you should confirm results

AMULET Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_amulet_test/make-test.289:
juju-test.conductor DEBUG : Tearing down osci-sv04 juju environment
juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv04"
WARNING cannot delete security group "juju-osci-sv04-0". Used by another environment?
juju-test INFO : Results: 3 passed, 0 failed, 0 errored

Full amulet output: http://paste.ubuntu.com/8638517/
Build: http://10.98.191.181:8080/job/charm_amulet_test/289/

charm_lint_check #165 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/165/

charm_unit_test #199 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/199/

charm_amulet_test #179 nova-compute-next for gnuoy mp238879
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 124
  make: *** [test] Error 124

Full amulet test output: http://paste.ubuntu.com/9527406/
Build: http://10.245.162.77:8080/job/charm_amulet_test/179/

charm_lint_check #709 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/709/

charm_unit_test #738 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/738/

charm_amulet_test #894 nova-compute-next for gnuoy mp238879
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/894/

T-J & U-J deploy tests fail with:

http://10.245.162.77:8080/view/Dashboard%3A%20Deploy/job/deploy_with_deployer/1254/artifact/

2015-01-13 11:41:57 [DEBUG] deployer.import: Waiting for units before adding relations
2015-01-13 11:42:01 [DEBUG] deployer.env: Delta unit: glance/0 change:error
2015-01-13 11:42:01 [ERROR] deployer.env: The following units had errors:
   unit: glance/0: machine: 6 agent-state: error details: hook failed: "install"
2015-01-13 11:42:01 [INFO] deployer.cli: Deployment stopped. run time: 310.34

2015-01-13 11:41:56 INFO juju.worker.uniter uniter.go:480 running "install" hook
2015-01-13 11:41:56 INFO worker.uniter.jujuc server.go:102 running hook tool "juju-log" ["Installing python-netifaces with options: ['--option=Dpkg::Options::=--force-confold']"]
2015-01-13 11:41:56 DEBUG worker.uniter.jujuc server.go:103 hook context id "glance/0:install:6741374157042095863"; dir "/var/lib/juju/agents/unit-glance-0/charm"
2015-01-13 11:41:56 INFO juju-log Installing python-netifaces with options: ['--option=Dpkg::Options::=--force-confold']
2015-01-13 11:41:56 INFO install Reading package lists...
2015-01-13 11:41:56 INFO install Building dependency tree...
2015-01-13 11:41:56 INFO install Reading state information...
2015-01-13 11:41:57 INFO install The following NEW packages will be installed:
2015-01-13 11:41:57 INFO install python-netifaces
2015-01-13 11:41:57 INFO install 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
2015-01-13 11:41:57 INFO install Need to get 16.7 kB of archives.
2015-01-13 11:41:57 INFO install After this operation, 77.8 kB of additional disk space will be used.
2015-01-13 11:41:57 INFO install WARNING: The following packages cannot be authenticated!
2015-01-13 11:41:57 INFO install python-netifaces
2015-01-13 11:41:57 INFO install E: There are problems and -y was used without --force-yes
2015-01-13 11:41:57 INFO install Traceback (most recent call last):
2015-01-13 11:41:57 INFO install File "/var/lib/juju/agents/unit-glance-0/charm/hooks/install", line 8, in <module>
2015-01-13 11:41:57 INFO install from glance_utils import (
2015-01-13 11:41:57 INFO install File "/var/lib/juju/agents/unit-glance-0/charm/hooks/glance_utils.py", line 6, in <module>
2015-01-13 11:41:57 INFO install import glance_contexts
2015-01-13 11:41:57 INFO install File "/var/lib/juju/agents/unit-glance-0/charm/hooks/glance_contexts.py", line 8, in <module>
2015-01-13 11:41:57 INFO install from charmhelpers.contrib.openstack.context import (
2015-01-13 11:41:57 INFO install File "/var/lib/juju/agents/unit-glance-0/charm/hooks/charmhelpers/contrib/openstack/context.py", line 48, in <module>
2015-01-13 11:41:57 INFO install from charmhelpers.contrib.openstack.neutron import (
2015-01-13 11:41:57 INFO install File "/var/lib/juju/agents/unit-glance-0/charm/hooks/charmhelpers/contrib/openstack/neutron.py", line 11, in <module>
2015-01-13 11:41:57 INFO install from charmhelpers.contrib.openstack.utils import os_release
2015-01-13 11:41:57 INFO install File "/var/lib/juju/agents/unit-glance-0/charm/hooks/charmhelpers/contrib/openstack/utils.py", line 31, in <module>
2015-01-13 11:41:57 I...

charm_lint_check #841 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/841/

charm_unit_test #870 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/870/

charm_amulet_test #1065 nova-compute-next for gnuoy mp238879
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/9783669/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1065/

charm_lint_check #869 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/869/

charm_unit_test #898 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/898/

charm_amulet_test #1093 nova-compute-next for gnuoy mp238879
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/9793840/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1093/

charm_lint_check #875 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/875/

charm_unit_test #904 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/904/

charm_amulet_test #1099 nova-compute-next for gnuoy mp238879
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/9794050/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1099/

FYI, icehouse deploy tests fail with:
(juno passes)

13:06:05 2015-01-20 13:06:05 [ERROR] deployer.env: The following units had errors:
13:06:05 unit: nova-compute/1: machine: 15 agent-state: error details: hook failed: "config-changed"

2015-01-20 13:06:02 INFO juju-log Rendering from template: nova.conf
2015-01-20 13:06:02 INFO config-changed Traceback (most recent call last):
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/config-changed", line 346, in <module>
2015-01-20 13:06:02 INFO config-changed main()
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/config-changed", line 340, in main
2015-01-20 13:06:02 INFO config-changed hooks.execute(sys.argv)
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/charmhelpers/core/hookenv.py", line 528, in execute
2015-01-20 13:06:02 INFO config-changed self._hooks[hook_name]()
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/charmhelpers/core/host.py", line 296, in wrapped_f
2015-01-20 13:06:02 INFO config-changed f(*args)
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/config-changed", line 125, in config_changed
2015-01-20 13:06:02 INFO config-changed CONFIGS.write_all()
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/charmhelpers/contrib/openstack/templating.py", line 261, in write_all
2015-01-20 13:06:02 INFO config-changed [self.write(k) for k in six.iterkeys(self.templates)]
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/charmhelpers/contrib/openstack/templating.py", line 250, in write
2015-01-20 13:06:02 INFO config-changed _out = self.render(config_file)
2015-01-20 13:06:02 INFO config-changed File "/var/lib/juju/agents/unit-nova-compute-1/charm/hooks/charmhelpers/contrib/openstack/templating.py", line 240, in render
2015-01-20 13:06:02 INFO config-changed return template.render(ctxt)
2015-01-20 13:06:02 INFO config-changed File "/usr/lib/python2.7/dist-packages/jinja2/environment.py", line 969, in render
2015-01-20 13:06:02 INFO config-changed return self.environment.handle_exception(exc_info, True)
2015-01-20 13:06:02 INFO config-changed File "/usr/lib/python2.7/dist-packages/jinja2/environment.py", line 742, in handle_exception
2015-01-20 13:06:02 INFO config-changed reraise(exc_type, exc_value, tb)
2015-01-20 13:06:02 INFO config-changed File "templates/icehouse/nova.conf", line 29, in top-level template code
2015-01-20 13:06:02 INFO config-changed {% include "parts/zeromq" %}
2015-01-20 13:06:02 INFO config-changed jinja2.exceptions.TemplateNotFound: parts/zeromq
2015-01-20 13:06:02 ERROR juju.worker.uniter uniter.go:486 hook failed: exit status 1

charm_lint_check #2213 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2213/

charm_unit_test #2002 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2002/

charm_amulet_test #2159 nova-compute-next for gnuoy mp238879
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10396600/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2159/

charm_lint_check #2683 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2683/

charm_unit_test #2474 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2474/

charm_amulet_test #2512 nova-compute-next for gnuoy mp238879
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10610210/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2512/

charm_lint_check #2693 nova-compute-next for gnuoy mp238879
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2693/

charm_unit_test #2484 nova-compute-next for gnuoy mp238879
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2484/

charm_amulet_test #2522 nova-compute-next for gnuoy mp238879
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/2522/

Approve