Merge lp://qastaging/~osomon/apparmor/newer-nvidia-abstraction-trunk into lp://qastaging/apparmor/2.12

Proposed by Olivier Tilloy
Status: Merged
Approved by: Tyler Hicks
Approved revision: 3646
Merged at revision: 3645
Proposed branch: lp://qastaging/~osomon/apparmor/newer-nvidia-abstraction-trunk
Merge into: lp://qastaging/apparmor/2.12
Diff against target: 21 lines (+5/-2)
1 file modified
profiles/apparmor.d/abstractions/nvidia (+5/-2)
To merge this branch: bzr merge lp://qastaging/~osomon/apparmor/newer-nvidia-abstraction-trunk
Reviewer Review Type Date Requested Status
Tyler Hicks Approve
Jamie Strandboge Approve
Review via email: mp+319120@code.qastaging.launchpad.net

Commit message

Update nvidia abstraction for newer nvidia drivers.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Some inline questions.

review: Needs Information
Revision history for this message
Tyler Hicks (tyhicks) wrote :

I'm just chiming in to say that I agree with Jamie here.

3646. By Olivier Tilloy

Specify device nodes instead of being too permissive.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for the feedback! Replied inline.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I mentioned '@{PROC}/driver/nvidia/params r,' but it is already included (sorry). Approve updated MP.

review: Approve
Revision history for this message
Tyler Hicks (tyhicks) wrote :

Looks good to me!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches