Chromium Browser

Merge lp://qastaging/~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641 into lp://qastaging/~chromium-team/chromium-browser/bionic-stable

  1. bionic-stable-osk-a11y-lp1697641
  2. Merge into bionic-stable
Proposed by Olivier Tilloy
Status: Needs review
Proposed branch: lp://qastaging/~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641
Merge into: lp://qastaging/~chromium-team/chromium-browser/bionic-stable
Diff against target: 33 lines (+15/-0)
2 files modified
debian/changelog (+7/-0)
debian/chromium-browser.sh.in (+8/-0)
To merge this branch: bzr merge lp://qastaging/~osomon/chromium-browser/bionic-stable-osk-a11y-lp1697641
Reviewer Review Type Date Requested Status
Chromium team Pending
Review via email: mp+347441@code.qastaging.launchpad.net

Commit message

* debian/chromium-browser.sh.in: conditionally enable accessibility for the on-screen keyboard to pop-up when a text field is focused (LP: #1697641)

To post a comment you must log in.
Revision history for this message
Mikhail Novosyolov (mikhailnov) wrote :

readonly osk_enabled=$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)

it would be better to use
readonly osk_enabled="$(gsettings get org.gnome.desktop.a11y.applications screen-keyboard-enabled)"

shellcheck can explain why very well

Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

shellcheck 0.5.0 doesn't complain about that particular line (it does issue a bunch of warnings/suggestions for other things in that script though).

Reply

Unmerged revisions

1423. By Olivier Tilloy

* debian/chromium-browser.sh.in: conditionally enable accessibility for the on-screen keyboard to pop-up when a text field is focused (LP: #1697641)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches