Merge lp://qastaging/~osomon/oxide/non-ime-initiated-text-edit into lp://qastaging/~oxide-developers/oxide/oxide.trunk
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~osomon/oxide/non-ime-initiated-text-edit |
| Merge into: | lp://qastaging/~oxide-developers/oxide/oxide.trunk |
| Diff against target: |
418 lines (+207/-18) 14 files modified
patches/notify-text-updates.patch (+135/-0) patches/series (+2/-0) patches/update-selection-on-non-ime-text-change.patch (+20/-0) qt/core/browser/oxide_qt_web_view.cc (+5/-1) qt/core/browser/oxide_qt_web_view.h (+1/-1) shared/browser/oxide_render_widget_host_view.cc (+24/-4) shared/browser/oxide_render_widget_host_view.h (+2/-1) shared/browser/oxide_render_widget_host_view_delegate.h (+2/-1) shared/browser/oxide_web_view.cc (+5/-3) shared/browser/oxide_web_view.h (+2/-1) shared/browser/oxide_web_view_client.cc (+1/-1) shared/browser/oxide_web_view_client.h (+1/-1) shared/port/content/browser/render_widget_host_view_oxide.cc (+4/-2) shared/port/content/browser/render_widget_host_view_oxide.h (+3/-2) |
| To merge this branch: | bzr merge lp://qastaging/~osomon/oxide/non-ime-initiated-text-edit |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Coulson | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Reset the input method and update the surrounding text reported to the keyboard if a non IME initiated edit was performed on the currently focused node.
Unmerged revisions
- 1030. By Olivier Tilloy
-
Merge the latest changes from trunk and resolve a conflict.
- 1029. By Michael Sheldon
-
Update the surrounding text reported to the keyboard when a text field is changed programmatically.
- 1028. By Olivier Tilloy
-
Merge the latest changes from trunk and resolve a conflict.
- 1027. By Olivier Tilloy
-
Refresh patch.
- 1026. By Olivier Tilloy
-
Merge the latest changes from trunk and resolve a few conflicts.
- 1025. By Olivier Tilloy
-
Merge the latest changes from trunk and resolve a couple of conflicts.
- 1024. By Olivier Tilloy
-
Reset the input method if a non IME initiated edit was performed on the currently focused node.
- 1023. By Olivier Tilloy
-
Add a patch to notify of text updates that were not triggered by user input in the focused element (e.g. programatically clearing a text field).
Thanks, I've left a comment inline