Merge lp://qastaging/~osomon/oxide/osk-visibility into lp://qastaging/~oxide-developers/oxide/oxide.trunk
Proposed by
Olivier Tilloy
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 785 | ||||
| Proposed branch: | lp://qastaging/~osomon/oxide/osk-visibility | ||||
| Merge into: | lp://qastaging/~oxide-developers/oxide/oxide.trunk | ||||
| Diff against target: |
17 lines (+4/-4) 1 file modified
qt/core/browser/oxide_qt_web_view.cc (+4/-4) |
||||
| To merge this branch: | bzr merge lp://qastaging/~osomon/oxide/osk-visibility | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Coulson | Approve | ||
|
Review via email:
|
|||
Commit message
Do not check whether the input method is currently visible in WebView:
to avoid a possible race condition: if hide() and show() are called very quickly in a row, when show() is called the hide() request might not have completed yet, and isVisible() could return true.
To post a comment you must log in.
Revision history for this message
| Chris Coulson (chrisccoulson) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
