Ubuntu UI Toolkit Extras

Merge lp://qastaging/~osomon/ubuntu-ui-extras/tabDelegate-objectName-index into lp://qastaging/ubuntu-ui-extras

tabDelegate-objectName-index
Merge into trunk

Proposed by Olivier Tilloy on 2017-03-22

Status:	Needs review
Proposed branch:	lp://qastaging/~osomon/ubuntu-ui-extras/tabDelegate-objectName-index
Merge into:	lp://qastaging/ubuntu-ui-extras
Diff against target:	12 lines (+1/-1) 1 file modified modules/Ubuntu/Components/Extras/TabsBar.qml (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~osomon/ubuntu-ui-extras/tabDelegate-objectName-index
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
system-apps-ci-bot	continuous-integration		Needs Fixing on 2017-05-17
Andrew Hayzen (community)		2017-03-22	Approve on 2017-03-22
Review via email: mp+320721@code.qastaging.launchpad.net

Commit message

Ease QML testing of client apps by including the index of the tab delegate in its object name.

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2017-03-22:

LGTM, I wonder if there is any performance difference between .arg() and just doing "tabDelegate_" + index

review: Approve

Revision history for this message

Olivier Tilloy (osomon) wrote on 2017-03-23:

I don’t know. I tend to use .arg() much more than plain string concatenation these days. I guess that would really matter if there were thousands of delegates, but that’s unlikely to ever happen with tabs, right?

Revision history for this message

Andrew Hayzen (ahayzen) wrote on 2017-03-23:

Yeah the difference is probably negligible :-)

Revision history for this message

system-apps-ci-bot (system-apps-ci-bot) wrote on 2017-05-17:

FAILED: Continuous integration, rev:131
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-ci/1/
Executed test runs:
FAILURE: https://jenkins.canonical.com/system-apps/job/build/2483/console
FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2483/console