Merge lp://qastaging/~osomon/unity-2d/panel-hover-fixes into lp://qastaging/unity-2d/3.0
Proposed by
Olivier Tilloy
| Status: | Merged |
|---|---|
| Approved by: | Olivier Tilloy |
| Approved revision: | 583 |
| Merged at revision: | 584 |
| Proposed branch: | lp://qastaging/~osomon/unity-2d/panel-hover-fixes |
| Merge into: | lp://qastaging/unity-2d/3.0 |
| Diff against target: |
58 lines (+7/-21) 2 files modified
panel/applets/appname/appnameapplet.cpp (+5/-19) panel/applets/appname/appnameapplet.h (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~osomon/unity-2d/panel-hover-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aurélien Gâteau (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
[panel] Show the current window’s menu only when the mouse cursor hovers over the appname applet, not the whole panel.
Description of the change
This merge request fixes bug #793403 and bug #793406. Both of them are low importance bugs, but they are a blocker for an OEM project based on Unity-2d, so a review of the fix would be very welcome. Thanks!
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, only suggestion would be to simplify the code checking whether the mouse is over the panel. This line:
&& (geometry(
Can be replaced with:
&& (rect()
Feel free to approve and get it merged after this change is done.