unity-webapps-qml

Merge lp://qastaging/~osomon/unity-webapps-qml/qmltypes into lp://qastaging/unity-webapps-qml

  1. qmltypes
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Rejected
Rejected by: Alberto Mardegan
Proposed branch: lp://qastaging/~osomon/unity-webapps-qml/qmltypes
Merge into: lp://qastaging/unity-webapps-qml
Diff against target: 47 lines (+13/-4)
3 files modified
debian/control (+1/-0)
src/Ubuntu/UnityWebApps/plugin/plugin.pro (+8/-1)
src/Ubuntu/UnityWebApps/qmldir.in (+4/-3)
To merge this branch: bzr merge lp://qastaging/~osomon/unity-webapps-qml/qmltypes
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Needs Fixing
PS Jenkins bot continuous-integration Pending
Review via email: mp+295242@code.qastaging.launchpad.net

Commit message

Generate and ship typeinfo for the QML module.

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

LGTM, but let me quickly test it.

Revision history for this message
Alberto Mardegan (mardy) wrote :

The build is failing with these errors:

=====================
qmlplugindump -v -noinstantiate Ubuntu.UnityWebApps 0.1 . > ../UnityWebApps.qmltypes
parsing <outputOfQmlimportscanner> skipping Ubuntu.UnityWebApps
appending dependency QtQuick 2.0
appending dependency Ubuntu.Components 0.1
appending dependency QtQuick 2.4
appending dependency Ubuntu.Components 1.3
appending dependency Ubuntu.Components.ListItems 1.3
appending dependency Ubuntu.Components.Popups 1.3
appending dependency QtQuick.Layouts 1.1
skipping private dependecy Ubuntu.Components.Private 1.3
appending dependency Ubuntu.PerformanceMetrics 1.0
appending dependency QtQuick.Window 2.2
appending dependency QtQuick.Window 2.0
appending dependency Ubuntu.Components.ListItems 1.0
appending dependency Ubuntu.Components 1.2
appending dependency Ubuntu.Components.Popups 1.0
appending dependency Ubuntu.Components 1.0
appending dependency Ubuntu.Components 1.1
appending dependency QtFeedback 5.0
Found a dependency on Ubuntu.Components with two major versions:0.1 and 1.0 which is unsupported, discarding smaller version
Found a dependency on Ubuntu.Components with two major versions:0.1 and 1.1 which is unsupported, discarding smaller version
Found a dependency on Ubuntu.Components with two major versions:0.1 and 1.2 which is unsupported, discarding smaller version
Found a dependency on Ubuntu.Components with two major versions:0.1 and 1.3 which is unsupported, discarding smaller version
Mandatory default theme "Ubuntu.Components.Themes.Ambiance" missing!
Theme not found: "Ubuntu.Components.Themes.Ambiance"
QQmlComponent: Component is not ready
file:///media/mardy/Data/src/bzr/unity-webapps-qml/qmltypes/src/Ubuntu/UnityWebApps/plugin/loaddependencies.qml:9:1: module "Ubuntu.PerformanceMetrics" is not installed
Makefile:293: recipe for target '../libUnityWebApps.so' failed
=====================

lp://qastaging/~osomon/unity-webapps-qml/qmltypes updated
161. By Olivier Tilloy

Add a build dependency on qtdeclarative5-dev-tools (for qmlplugindump).

162. By Olivier Tilloy

Fix the reference path of the module passed to qmlplugindump.

Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m getting the following error when building in a clean chroot:

qmlplugindump -v -noinstantiate Ubuntu.UnityWebApps 0.1 ../../.. > ../UnityWebApps.qmltypes
parsing <outputOfQmlimportscanner> skipping Ubuntu.UnityWebApps
QQmlComponent: Component is not ready
file:///tmp/qmltypes/b/src/typelist.qml: Script file:///tmp/qmltypes/b/src/Ubuntu/UnityWebApps/UnityWebApps.js unavailable
file:///tmp/qmltypes/b/src/Ubuntu/UnityWebApps/UnityWebApps.js: File not found

This is because the QML and JS files don’t live in the same folder as the generated qmldir and .so files. They would need to be copied to the outdir as a prerequisite to calling qmlplugindump.

review: Needs Fixing
Revision history for this message
Alberto Mardegan (mardy) wrote :

Taking over this branch in https://code.launchpad.net/~mardy/unity-webapps-qml/qmltypes/+merge/295307

Unmerged revisions

162. By Olivier Tilloy

Fix the reference path of the module passed to qmlplugindump.

161. By Olivier Tilloy

Add a build dependency on qtdeclarative5-dev-tools (for qmlplugindump).

160. By Olivier Tilloy

Generate and ship typeinfo for the QML module.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: