Merge lp://qastaging/~osomon/unity/4.0-dash-custom-home-screen into lp://qastaging/unity/4.0
Proposed by
Olivier Tilloy
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Gord Allott | ||||
| Proposed branch: | lp://qastaging/~osomon/unity/4.0-dash-custom-home-screen | ||||
| Merge into: | lp://qastaging/unity/4.0 | ||||
| Diff against target: |
72 lines (+28/-4) 1 file modified
plugins/unityshell/src/PlacesHomeView.cpp (+28/-4) |
||||
| To merge this branch: | bzr merge lp://qastaging/~osomon/unity/4.0-dash-custom-home-screen | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gord Allott (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Do not rely solely on the executable name to launch an application, this doesn’t work for applications that are launched with parameters.
Use g_app_info_
To post a comment you must log in.
Unmerged revisions
- 1723. By Olivier Tilloy
-
Do not rely solely on the executable name to launch an application, this doesn’t work for applications that are launched with parameters.
Use g_app_info_
launch( …) instead.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
On Tue 10 Jan 2012 08:52:40 GMT, Olivier Tilloy wrote:
> Olivier Tilloy has proposed merging lp:~osomon/unity/4.0-dash-custom-home-screen into lp:unity/4.0.
>
> Requested reviews:
> Unity Team (unity-team)
> Related bugs:
> Bug #913885 in unity (Ubuntu): "Custom dash shortcut to desktop file drops Exec args"
> https:/
>
> For more details, see:
> https:/
Looks good to me, desktop files are great ;) approving
review approve
status approved
--
Gordon Allott
Canonical Ltd.
27 Floor, Millbank Tower
London SW1P 4QP
www.canonical.com