webbrowser-app

Merge lp://qastaging/~osomon/webbrowser-app/settings-checkboxes-for-verbs into lp://qastaging/webbrowser-app

  1. settings-checkboxes-for-verbs
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1005
Merged at revision: 1014
Proposed branch: lp://qastaging/~osomon/webbrowser-app/settings-checkboxes-for-verbs
Merge into: lp://qastaging/webbrowser-app
Diff against target: 155 lines (+32/-26)
1 file modified
src/app/webbrowser/SettingsPage.qml (+32/-26)
To merge this branch: bzr merge lp://qastaging/~osomon/webbrowser-app/settings-checkboxes-for-verbs
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Riccardo Padovani (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+258967@code.qastaging.launchpad.net

Commit message

Use checkboxes instead of switches for verb phrases, per design guidance.

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Code looks good.
I tested it on desktop and seems to work well too. Thanks :-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1005
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1751/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2769/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/508
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/508
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/508/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/508
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2387/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2767
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2767/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20449

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1751/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: