webbrowser-app

Merge lp://qastaging/~osomon/webbrowser-app/smartbanners into lp://qastaging/webbrowser-app

  1. smartbanners
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 586
Merged at revision: 592
Proposed branch: lp://qastaging/~osomon/webbrowser-app/smartbanners
Merge into: lp://qastaging/webbrowser-app
Diff against target: 51 lines (+36/-0)
2 files modified
src/Ubuntu/Web/UbuntuWebContext.qml (+6/-0)
src/Ubuntu/Web/smartbanners.js (+30/-0)
To merge this branch: bzr merge lp://qastaging/~osomon/webbrowser-app/smartbanners
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Adnane Belmadiaf (community) community Approve
Ubuntu Phablet Team Pending
Review via email: mp+224824@code.qastaging.launchpad.net

Commit message

Add a user script that prevents so-called "smart banners" generated by the smartbanner jQuery plugin to show ads for native android/iOS apps.

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

+1

review: Approve (community)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:586
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/897/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1300
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1141
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/96
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/96
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/96/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/96
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1615
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2202
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2202/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8951
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/942
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1284
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1284/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/897/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: