webbrowser-app

Merge lp://qastaging/~osomon/webbrowser-app/webProcessStatus into lp://qastaging/webbrowser-app

webProcessStatus
Merge into trunk

Proposed by Olivier Tilloy on 2015-05-13

Status:

Merged

Approved by:

Olivier Tilloy on 2015-09-02

Approved revision:

1026

Merged at revision:

1159

Proposed branch:

lp://qastaging/~osomon/webbrowser-app/webProcessStatus

Merge into:

lp://qastaging/webbrowser-app

Diff against target:

650 lines (+460/-34)

10 files modified

debian/control (+1/-0)
src/app/WebProcessMonitor.qml (+79/-0)
src/app/webbrowser/Browser.qml (+40/-19)
src/app/webbrowser/SadTab.qml (+92/-0)
src/app/webbrowser/tabs-model.cpp (+4/-3)
tests/autopilot/webbrowser_app/emulators/browser.py (+16/-0)
tests/autopilot/webbrowser_app/tests/__init__.py (+11/-0)
tests/autopilot/webbrowser_app/tests/test_sad_tab.py (+74/-0)
tests/unittests/qml/tst_WebProcessMonitor.qml (+108/-0)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+35/-12)

To merge this branch:

bzr merge lp://qastaging/~osomon/webbrowser-app/webProcessStatus

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-09-02
Riccardo Padovani (community)			Approve on 2015-09-02
Ubuntu Phablet Team		2015-05-13	Pending
Review via email: mp+259040@code.qastaging.launchpad.net

Commit message

Display a friendly message when the renderer process crashes or is killed.
This adds a runtime dependency for webbrowser-app-autopilot on python3-psutil.

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-05-13

1009. By Olivier Tilloy on 2015-05-13: Revert unnecessary version bump.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-13:

FAILED: Continuous integration, rev:1009
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1759/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2791/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/516/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/516/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/516/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2789/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1759/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-05-14

1010. By Olivier Tilloy on 2015-05-14: Also bump the build dependency on oxide to allow unit tests to run at build time.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-14:

FAILED: Continuous integration, rev:1010
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1763/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2805/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/520/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/520/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/520/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2803/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1763/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-05-14

1011. By Olivier Tilloy on 2015-05-14: Count the number of retries (but keep it limited to one for now).
1012. By Olivier Tilloy on 2015-05-14: Merge the latest changes from trunk and resolve a conflict.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-05-14:

FAILED: Continuous integration, rev:1012
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1764/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2807/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/521/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/521/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/521/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2805/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1764/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-06-12

1013. By Olivier Tilloy on 2015-06-12: Simplify the code a bit.
1014. By Olivier Tilloy on 2015-06-12: Merge the latest changes from trunk and resolve a couple of conflicts.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-06-12:

FAILED: Continuous integration, rev:1014
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1885/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3185/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/642/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/642/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/642/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3183/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1885/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-06-12

1015. By Olivier Tilloy on 2015-06-12: Make the SadTab component browser-specific.
1016. By Olivier Tilloy on 2015-06-12: Updated SadTab to match visual specification.
1017. By Olivier Tilloy on 2015-06-12: Fix the sad tab disappearing after a minute.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-06-12:

FAILED: Continuous integration, rev:1017
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1887/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3188/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/644/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/644/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/644/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3186/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1887/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-07-03

1018. By Olivier Tilloy on 2015-07-03: Merge the latest changes from trunk and resolve conflicts.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-03:

FAILED: Continuous integration, rev:1018
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1956/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3364/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/713/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/713/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/713/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3362/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1956/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-08-03

1019. By Olivier Tilloy on 2015-08-03: Merge the latest changes from trunk and resolve a conflict.
1020. By Olivier Tilloy on 2015-08-03: Fix autopilot tests on desktop where closing the last open tab exits the application.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-03:

FAILED: Continuous integration, rev:1020
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2026/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3558/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/780/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/780/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/780/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3555/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2026/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-08-12

1021. By Olivier Tilloy on 2015-08-12: Merge the latest changes from trunk.
1022. By Olivier Tilloy on 2015-08-12: Update imports.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-12:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2079/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Riccardo Padovani (rpadovani) wrote on 2015-08-31:

Useful function, thanks!

lgtm, just a note in the code I don't understand.

review: Needs Information

lp://qastaging/~osomon/webbrowser-app/webProcessStatus updated on 2015-09-02

1023. By Olivier Tilloy on 2015-09-02: Merge the latest changes from trunk.
1024. By Olivier Tilloy on 2015-09-02: Fix closing the current tab (the assumption that the current tab is always the first one is not valid any longer).
1025. By Olivier Tilloy on 2015-09-02: Use name() instead of exe() to avoid raising an AccessDenied exception.

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-09-02:

> I don't understand this: if it should close the current tab,
> why does it close the first?

Very good catch, thanks Riccardo!
The assumption [current tab == first tab] used to be true when we supported only the mobile form factor, where the current tab was always pushed to the top of the stack. This is not valid any longer, so I updated the code to reflect that.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-02: