Merge lp://qastaging/~osomon/webbrowser-app/zoom-qwerty-keyboard into lp://qastaging/webbrowser-app
Proposed by
Olivier Tilloy
| Status: | Merged |
|---|---|
| Approved by: | Bill Filler |
| Approved revision: | 1536 |
| Merged at revision: | 1537 |
| Proposed branch: | lp://qastaging/~osomon/webbrowser-app/zoom-qwerty-keyboard |
| Merge into: | lp://qastaging/webbrowser-app |
| Diff against target: |
55 lines (+27/-0) 2 files modified
src/app/webbrowser/Browser.qml (+16/-0) tests/autopilot/webbrowser_app/tests/test_keyboard.py (+11/-0) |
| To merge this branch: | bzr merge lp://qastaging/~osomon/webbrowser-app/zoom-qwerty-keyboard |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bill Filler (community) | Approve | ||
| system-apps-ci-bot | continuous-integration | Needs Fixing | |
| Andrew Hayzen (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add "Ctrl+=" and "Ctrl+_" as shortcuts for zoom in and zoom out actions,
for improved compatibility with qwerty-based keyboard layouts.
To post a comment you must log in.
Revision history for this message
| system-apps-ci-bot (system-apps-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Tested on various keyboard layouts on unity7.
LGTM and unit tests pass :-)