Merge ~paelzer/ubuntu/+source/chrony:bionic-lp1764357 into ubuntu/+source/chrony:ubuntu/devel

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: a43489f69cca92440ec4b93c609951409c73fd27
Proposed branch: ~paelzer/ubuntu/+source/chrony:bionic-lp1764357
Merge into: ubuntu/+source/chrony:ubuntu/devel
Diff against target: 199 lines (+136/-1)
7 files modified
debian/changelog (+13/-0)
debian/control (+1/-0)
debian/links (+5/-0)
debian/patches/lp-1718227-ignore-non-up-down-events-in-nm-dispatcher.patch (+32/-0)
debian/patches/lp-1718227-nm-dispatcher-for-networkd.patch (+67/-0)
debian/patches/series (+2/-0)
debian/postrm (+16/-1)
Reviewer Review Type Date Requested Status
Steve Langasek (community) Needs Fixing
Nish Aravamudan (community) Approve
Canonical Server packageset reviewers Pending
git-ubuntu developers Pending
Review via email: mp+343328@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Tested from ppa [1] and working in my VM.
That said ready for review.

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3242

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Added the changes that I brought upstream and the related packaging changes for bug 1718227.

I also updated the version in the PPA.

Revision history for this message
Nish Aravamudan (nacc) wrote :

Agree with the changes, please upload tag & upload.

review: Approve
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Fixing
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The base file is a conffile, the links are not.
Not in /etc nor in /usr/lib - I think that is ok for now as any changes needed could be done in the one conffile that it is.

I'll add a versioned dependency for the new path and wait until 1765152 is resolved with my upload.
Thanks Steve for letting me know about this!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Fixups according to Julians change for bug 1765152 pushed.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Tested with my ppa (as I'll upload) and the networkd-dispatcher from -proposed.
All good.

Tags pushed and uploading to bionic(-unapproved)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches