Code review comment for ~paelzer/ubuntu/+source/ipxe:merge-ipxe-groovy-36a4c85-5

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok, will do this in several steps.

First bit:

This commit is missing the mention of d/control:
commit f52d57afafbd9d2de5905263d701f87b374194dc
Author: Christian Ehrhardt <email address hidden>
Date: Tue Aug 29 15:11:37 2017 +0200

    d/util/check-rom-sizes, d/rules: check sizes of generated roms (LP: #1713490)

    Signed-off-by: Christian Ehrhardt <email address hidden>

diff --git a/debian/control b/debian/control
index d9b6e476..c85178bf 100644
--- a/debian/control
+++ b/debian/control
@@ -33,6 +33,7 @@ Package: ipxe-qemu
 Architecture: all
 Multi-Arch: foreign
 Depends: ${misc:Depends}
+Breaks: qemu-system-x86 (<< 1:2.11+dfsg-1ubuntu1~)
 Description: PXE boot firmware - ROM images for qemu
  iPXE is network boot firmware. It supports a variety of network cards,
  including some wireless cards, and variety of network protocols (traditional
....

From an older d/changelog, it's this probably: "- d/control: break older qemu versions to ensure the new sized roms"

Do we still need this breaks, btw?

« Back to merge proposal