Code review comment for ~paelzer/ubuntu/+source/ipxe:merge-ipxe-groovy-36a4c85-5

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Since this is a complicated merge, I'm going through the logical in more detail. I think you missed a consolidation step (on purpose perhaps?) as there are commits adding patches and later one removing them:

2ae0e4801eadae1d064ef1c50cfc608ec200caea
DROP (Debian): drop patches no more needed with 20180124.fbe8c52d
This drops:
0002-Don-t-use-libiberty.patch
0004-fix_no-pie_option.patch
0006-build-Fix-.ids.o-creation-for-drivers-not-in-the-all.patch
0007-build-Remove-nested-my-declaration.patch

Which are indeed not in pkg/ubuntu/devel at the moment. But they were added by these commits also inside the logical chunk:
60ca2e05 0002-Don-t-use-libiberty.patch
d4ca5cdc 0004-fix_no-pie_option.patch
c9ce6c19 0006 and 0007 patches

So, since the logical (and I'm talking about lp1884758/old/debian..lp1884758/logical/1.0.0+git-20190109.133f4c4-0ubuntu3) adds them and removes them later on, couldn't these just be removed from logical entirely, and not just "scheduled" for removal when you apply this on top of new/debian?

review: Needs Information

« Back to merge proposal