Code review comment for ~paelzer/ubuntu/+source/ipxe:merge-ipxe-groovy-36a4c85-5

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

@andreas about the addition&removal of patches like 0002-Don-t-use-libiberty.patch
This was due to the "going ahead of Debian". In fact at some point we reverted to go onto an earlier version, this made these patches "again being required" and later on when moving forward got removed again.

This wasn't exactly the same as when we usually add/remove patches. And I thought the history is more readable the way I presented them.

If you want I can squash them away.
I have made the former logical tag -v6 and pushed a new logical tag.

P.S. That is the reason there are multiple logical..-v* tags in case you ever wonder how I came from split to the final --logical (to be able to trace the steps).

This squashed the following commits into a no-op:
  d4ca5cdc4 DROP (upsteram): - d/p/0004-fix_no-pie_option.patch: correct -no-pie option to build without pie
  60ca2e055 DROP (Debian) - This brings back debian/patches/0002-Don-t-use-libiberty.patch as needed on the older source.
  c9ce6c192 DROP (upstream): fix FTBFS with newer perl versions
  2ae0e4801 DROP (Debian): drop patches no more needed with 20180124.fbe8c52d

The updated lp1884758/logical/1.0.0+git-20190109.133f4c4-0ubuntu3 should match what you have expected.

To ssh://git.launchpad.net/~paelzer/ubuntu/+source/ipxe
 * [new tag] lp1884758/logical/1.0.0+git-20190109.133f4c4-0ubuntu3-v6 -> lp1884758/logical/1.0.0+git-20190109.133f4c4-0ubuntu3-v6
 + 6ced0f108...a0fbb52a7 lp1884758/logical/1.0.0+git-20190109.133f4c4-0ubuntu3 -> lp1884758/logical/1.0.0+git-20190109.133f4c4-0ubuntu3 (forced update)

« Back to merge proposal